Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lattice-diamond: add libusb-compat-0_1 dependency #89976

Merged
merged 1 commit into from Aug 22, 2020

Conversation

yrashk
Copy link
Contributor

@yrashk yrashk commented Jun 9, 2020

Lattice Diamond won't be able to produce a PROM file
without libusb 0.1 so one has to be supplied.

Motivation for this change

Can't use Lattice Diamond productively without this change.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Lattice Diamond won't be able to produce a PROM file
without libusb 0.1 so one has to be supplied.
@q3k
Copy link
Member

q3k commented Jun 21, 2020

Haven't tested that this works/fixes things (don't have a good testbench for using Diamond right now), but the change itself looks sensible.

@Lassulus Lassulus merged commit c87a9ed into NixOS:master Aug 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants