Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.spidev: init at 3.5 #90000

Merged
merged 1 commit into from Jul 6, 2020
Merged

pythonPackages.spidev: init at 3.5 #90000

merged 1 commit into from Jul 6, 2020

Conversation

mweinelt
Copy link
Member

Motivation for this change

I need this library to control APA102 LEDs ✨ on my ReSpeaker Mic Array 🎤.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bhipple
Copy link
Contributor

bhipple commented Jul 5, 2020

Needs a rebase; otherwise LGTM

@mweinelt
Copy link
Member Author

mweinelt commented Jul 6, 2020

@bhipple Done, thanks for the review.

@bhipple
Copy link
Contributor

bhipple commented Jul 6, 2020

Result of nixpkgs-review pr 90000 1

3 packages built:
- python27Packages.spidev
- python37Packages.spidev
- python38Packages.spidev

@bhipple bhipple merged commit f02c41e into NixOS:master Jul 6, 2020
@mweinelt mweinelt deleted the python-spidev branch April 1, 2021 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evils evils evils left review comments

@bhipple bhipple bhipple approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mweinelt @bhipple @evils