Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change style for "Center of Mass" entity #638

Closed
ghost opened this issue Jun 23, 2020 · 5 comments
Closed

Change style for "Center of Mass" entity #638

ghost opened this issue Jun 23, 2020 · 5 comments
Labels

Comments

@ghost
Copy link

ghost commented Jun 23, 2020

System information

SolveSpace version: 3.0~d238f985

Operating system: Debian 10 buster

Expected behavior

"Center of Mass" entity (which by design is reference dimension) should use #def-constraint style, which also used for "show areas of closed contours" entities and all other dimension-related entities (constraints).

Actual behavior

"Center of Mass" entity use #def-datum style, which looks wrong.

Additional information

@whitequark
Copy link
Contributor

whitequark commented Jun 23, 2020

The displayed center of mass is not an entity or a constraint; it's not a part of the sketch at all. The color is the same as for the origin of the plane shown when you export in 2d, since they serve similar functions.

@ghost
Copy link
Author

ghost commented Jun 23, 2020

The displayed center of mass is not an entity or a constraint

OK, but I suggest it should be "entity".

May I request it here? It would be really useful for export drawings where "Center of Mass" could be shown.

@whitequark
Copy link
Contributor

It can't be an entity; given how SolveSpace currently works, entities (things you can constrain / constrain to) can't really be based on solid geometry.

On the other hand, exporting it seems reasonable.

@ghost
Copy link
Author

ghost commented Jun 23, 2020

It can't be an entity; given how SolveSpace currently works, entities (things you can constrain / constrain to) can't really be based on solid geometry.

Why not?

Suggest center of mass entity is similar to area ("show are of closed contours") entity, but instead of area entity which position is constrained to center of mass of closed contour in 2D, center of mass entity should be in 3D (similar to comment entities which already could be placed in 3D, but center of mass entity should not be dragged by mouse and its origin position should be always constrained to calculated center of mass position).

@whitequark
Copy link
Contributor

Why not?

Because generating a sketch is a two-step process (first it is solved, second the solid geometry is generated based on the solution) and it would be difficult to change that. I'm also not really interested in any abstract discussion of features with you specifically, because you consistently fail to engage in such discussions in good faith.

@solvespace solvespace locked as resolved and limited conversation to collaborators Jun 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant