k4dirstat: init at 3.2.1 #91345
Merged
k4dirstat: init at 3.2.1 #91345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvarWithoutBones
requested changes
Jun 24, 2020
There was a problem hiding this comment.
Some spacing + meta stuff seems odd, heres a suggestion:
{ stdenv
, mkDerivation
, fetchFromGitHub
, extra-cmake-modules
, kdoctools
, kiconthemes
, kio
, kjobwidgets
, kxmlgui
}:
mkDerivation rec {
pname = "k4dirstat";
version = "3.2.1";
src = fetchFromGitHub {
owner = "jeromerobert";
repo = pname;
rev = version;
sha256 = "15xjb80jq6vhzvzx4l341f40d8a23w1334qh6cczqm9adfnzycp7";
};
nativeBuildInputs = [ extra-cmake-modules kdoctools kxmlgui ];
buildInputs = [ kiconthemes kio kjobwidgets ];
meta = with stdenv.lib; {
homepage = "https://github.com/jeromerobert/k4dirstat";
description = "A small utility program that sums up disk usage for directory trees";
license = licenses.gpl2;
maintainers = [ maintainers.raboof ];
platforms = platforms.linux;
};
}| }; | ||
| nativeBuildInputs = [ extra-cmake-modules kdoctools kxmlgui ]; | ||
| buildInputs = [ kiconthemes kio kjobwidgets ]; | ||
| propagatedBuildInputs = [ ]; |
There was a problem hiding this comment.
This defaults to being empty, no? You can just remove it.
| description = "A small utility program that sums up disk usage for directory trees"; | ||
| maintainers = [ lib.maintainers.raboof ]; | ||
| }; | ||
| nativeBuildInputs = [ extra-cmake-modules kdoctools kxmlgui ]; |
There was a problem hiding this comment.
Shouldn't kdoctools and kxmlgui be regular buildInputs?
raboof
force-pushed
the
k4dirstat-init-at-3.2.1
branch
from
59b7df8
to
b5b84be
Compare
|
Updated, thanks! |
|
Result of 1 package built:- k4dirstat |
|
GUI works for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)