Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[haskell-updates] haskellPackages.jsaddle-warp: Fix build #91315

Merged
merged 1 commit into from Jun 23, 2020
Merged

[haskell-updates] haskellPackages.jsaddle-warp: Fix build #91315

merged 1 commit into from Jun 23, 2020

Conversation

maralorn
Copy link
Member

Motivation for this change

Fixing build:

  • Disabling tests
  • Bumping version constraint (reported to upstream)
  • Marked unbroken
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cdepillabout
Copy link
Member

Looks like it is building on Linux, thanks!

@cdepillabout cdepillabout merged commit 41439b4 into NixOS:haskell-updates Jun 23, 2020
@maralorn maralorn deleted the fix-jsaddle-warp branch June 23, 2020 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

Assignees
No one assigned
Labels
6.topic: haskell 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maralorn @cdepillabout