Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.tinycss2: fix failing tests #91364

Closed
wants to merge 2 commits into from

Conversation

misuzu
Copy link
Contributor

@misuzu misuzu commented Jun 23, 2020

Motivation for this change

https://hydra.nixos.org/build/122651822

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

pkgs/development/python-modules/tinycss2/default.nix Outdated Show resolved Hide resolved
@jonringer jonringer mentioned this pull request Jun 24, 2020
10 tasks
@balsoft
Copy link
Member

balsoft commented Jun 29, 2020

@GrahamcOfBorg build python3Packages.tinycss2 python3Packages.cssselect2

@balsoft
Copy link
Member

balsoft commented Jun 29, 2020

Some tests fail, but the build still succeeds ^

@misuzu
Copy link
Contributor Author

misuzu commented Jun 29, 2020

Some tests fail, but the build still succeeds ^

This is fine: https://travis-ci.org/github/Kozea/cssselect2/jobs/663252998

@misuzu misuzu closed this Jul 2, 2020
@misuzu misuzu deleted the tinycss2-tests-fix branch April 22, 2021 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants