Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "digits after decimal point to show" for volume, area, perimeter & center of mass #637

Closed
ghost opened this issue Jun 23, 2020 · 6 comments
Labels

Comments

@ghost
Copy link

ghost commented Jun 23, 2020

System information

SolveSpace version: 3.0~d238f985

Operating system: Debian 10 buster

Expected behavior

There should be additional options to control "digits after decimal point to show" for volume, area, perimeter & center of mass (in same way as distances and angles)

Actual behavior

Actually "digits after decimal point to show" for volume, area, perimeter & center of mass are hardcoded and there are no way to show those values more precisely if needed (especially for small solids & drawings).

Additional information

@whitequark
Copy link
Contributor

Actually "digits after decimal point to show" for volume, area, perimeter & center of mass are hardcoded

That's not the case, which you would know if you read the code before making authoritative statements about the function of that code. Those values always use SI prefixes and they use the same amount of digits after the decimal point as distances do.

@ghost
Copy link
Author

ghost commented Jun 23, 2020

Those values always use SI prefixes and they use the same amount of digits after the decimal point as distances do.

At least not center of mass entity use SI prefixes.

Also perimeter area entities follow the state of "use SI prefixes for distances" option.

EDIT: I mean area here, not perimeter. And here is another issue: #639

@whitequark
Copy link
Contributor

At least not center of mass entity use SI prefixes.

Fixed in 35c6af4.

Also perimeter entities follow the state of "use SI prefixes for distances" option.

A perimeter is a distance (alongside the contour, that is).

@ghost
Copy link
Author

ghost commented Jun 23, 2020

A perimeter is a distance(alongside the contour, that is)

If so, it should also use "digits after decimal point to show: distances", but actually perimeter is hardcoded to 3 digits after decimal point to show.

So, I propose to fix perimeter to follow "digits after decimal point to show: distances" option too.

EDIT: I mean area here, not perimeter.

@whitequark
Copy link
Contributor

but actually perimeter is hardcoded to 3 digits after decimal point to show.

Of course it isn't.
Screenshot_20200623_013037
Screenshot_20200623_013048

@ghost
Copy link
Author

ghost commented Jun 23, 2020

@whitequark, Sorry me here, I really mean area in this comment above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant