Fix for 'Huge screenshot' warning being shown incorrectly #8235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commit checker has failed. The commit message should be in the form "Fix #8232: ...". |
|
Updated - thanks. |
abmyii
force-pushed
the
screenshot_warning_8232
branch
from
2fd23f5
to
a83bd03
Compare
techgeeknz
reviewed
Jun 26, 2020
There was a problem hiding this comment.
We actually have more than one implementation of the screenshot function, which I'm currently trying to solve. I'll cherry-pick your commit into #8224
Cool. I assume this PR should be closed in favour of yours? |
We'll let the maintainers decide that one. I'll rebase my branch on yours if the cards fall in your favour. |
|
Thanks both, I've merged @techgeeknz 's PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8232.