Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hydra-unstable: 2020-06-01 -> 2020-06-23 #91357

Merged
merged 1 commit into from Jun 24, 2020
Merged

hydra-unstable: 2020-06-01 -> 2020-06-23 #91357

merged 1 commit into from Jun 24, 2020

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Jun 23, 2020

Motivation for this change

Fixes the build the changes from b505bf2.

Can be backported if the nixFlakes bump is backported as well.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27
hydra-unstable: 2020-06-01 -> 2020-06-23
39e3c15 
Fixes the build the changes from b505bf2.
@Ma27 Ma27 requested review from grahamc and edolstra June 23, 2020 14:01
@Ma27 Ma27 added the 9.needs: port to stable A PR needs a backport to the stable release. label Jun 24, 2020
@Ma27 Ma27 merged commit 7be82cc into NixOS:master Jun 24, 2020
@Ma27 Ma27 deleted the bump-hydra branch June 24, 2020 21:25
@Ma27 Ma27 restored the bump-hydra branch June 24, 2020 21:25
@Ma27 Ma27 deleted the bump-hydra branch June 24, 2020 21:25
@Ma27
Copy link
Member Author

Ma27 commented Jun 24, 2020

Ported to stable as f8248ab since the nixFlakes bump has been backported yesterday, so this fix is also required on stable.

@Ma27 Ma27 added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamc grahamc Awaiting requested review from grahamc

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Ma27