Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust-analyzer: 2020-06-08 -> 2020-07-13, and fix version display #91359

Merged
merged 4 commits into from Jul 14, 2020

Conversation

oxalica
Copy link
Contributor

@oxalica oxalica commented Jun 23, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@oxalica oxalica changed the title rust-analyzer: 2020-06-08 -> 2020-06-22, and fix version display rust-analyzer: 2020-06-08 -> 2020-06-29, and fix version display Jun 30, 2020
@oxalica oxalica changed the title rust-analyzer: 2020-06-08 -> 2020-06-29, and fix version display rust-analyzer: 2020-06-08 -> 2020-07-06, and fix version display Jul 8, 2020
@oxalica
Copy link
Contributor Author

oxalica commented Jul 8, 2020

Bumped to 2020-07-06 and add check for output of --version.

@lovesegfault
Copy link
Member

Pinging @flokli @jonringer for merging

@oxalica
Copy link
Contributor Author

oxalica commented Jul 14, 2020

Rebased and fixed build

@oxalica oxalica changed the title rust-analyzer: 2020-06-08 -> 2020-07-06, and fix version display rust-analyzer: 2020-06-08 -> 2020-07-13, and fix version display Jul 14, 2020
@flokli flokli merged commit b0a1073 into NixOS:master Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants