Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/patchelf
base: 61e2913c31f3
Choose a base ref
...
head repository: NixOS/patchelf
compare: 1e1867de9016
Choose a head ref
  • 3 commits
  • 4 files changed
  • 3 contributors

Commits on Jun 19, 2020

  1. Improve the default section alignment choice

    Currently patchelf uses the host system's page size (determined at build
    time) as the default section load memory alignment. This causes multiple
    issues
    
    - Cross-compilation: when using patchelf on ELFs targetting a different
      architecture from the host, the host page size is still used by
      default.
    
    - Variable page size architectures: ARMv8 systems can be configured in
      either 4K, 16K, or 64K page size mode depending on kernel
      configuration. An ARMv8 patchelf built on a 4K page size system will
      end up creating ELFs that cannot be used on a 64K page size system.
    
    - Reproducibility: the page size of the machine that built patchelf
      "leaks" into the binary.
    
    The build time --with-page-size as well as the run time --page-size
    options can be used to work around some of these issues. But it's much
    better to have patchelf do the right thing without explicit
    configuration.
    
    This commit adds support for inferring page size from the ELF header's
    "machine" field. The default values are extracted from GNU gold's source
    code. Note that both --with-page-size as well as --page-size continue to
    work and take precedence on the default value.
    delroth committed Jun 19, 2020
    Copy the full SHA
    0470d69 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2020

  1. Merge pull request #216 from delroth/pagesize

    Improve the default section alignment choice (> 4K page size compat)
    edolstra committed Jun 23, 2020
    Copy the full SHA
    33daa5a View commit details
    Browse the repository at this point in the history
  2. CI for aarch64

    domenkozar committed Jun 23, 2020
    1
    Copy the full SHA
    1e1867d View commit details
    Browse the repository at this point in the history