Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cppcheck: enable z3 support #88934

Merged
merged 1 commit into from May 27, 2020
Merged

cppcheck: enable z3 support #88934

merged 1 commit into from May 27, 2020

Conversation

Flakebi
Copy link
Member

@Flakebi Flakebi commented May 26, 2020

Motivation for this change

cppcheck gained support to use Z3 in version 2.0: https://sourceforge.net/p/cppcheck/news/2020/05/cppcheck-20/

$ nix path-info -hS /nix/store/x7qm2iic30smcdfccdh8klyf9y0rl5ia-cppcheck-2.0
/nix/store/x7qm2iic30smcdfccdh8klyf9y0rl5ia-cppcheck-2.0          45.0M
$ nix path-info -hS /nix/store/yfpb8vq19gkmr0wvlsqyhkjvlah6yclb-cppcheck-2.0
/nix/store/yfpb8vq19gkmr0wvlsqyhkjvlah6yclb-cppcheck-2.0         131.3M
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from joachifm May 26, 2020 11:10
@Ma27
Copy link
Member

Ma27 commented May 27, 2020

I'd say that the closure size increase is fine here since cppcheck is a devtool in the end and the Z3-addition to check expressions is IMHO a nice feature 👍

@Ma27 Ma27 merged commit 7fe32a6 into NixOS:master May 27, 2020
@Flakebi Flakebi deleted the cppcheck-z3 branch May 27, 2020 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joachifm joachifm Awaiting requested review from joachifm

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Flakebi @Ma27