mfc9332cdw: init at 1.1.3-0/1.1.4-0 #88914
Conversation
felixsinger
force-pushed
the
add-pkgs/cups/drivers/mfc9332cdw
branch
from
3129ac8
to
55e3afa
Compare
|
@felixsinger Thanks a lot for your contribution! I've left a couple of comments |
felixsinger
force-pushed
the
add-pkgs/cups/drivers/mfc9332cdw
branch
from
202936b
to
cc7700d
Compare
|
@NickHu Done |
There was a problem hiding this comment.
I guess the final thing to do is change the commit and PR title to something like
mfc9332cdw: init at 1.1.3-0
There is also no corresponding entry in pkgs/top-level/all-packages.nix, so how exactly are you building and using this? There are a bunch of Brother drivers scattered in pkgs/misc/cups/drivers, but you're right that they should probably sit in their own subdirectory. There is certainly a lot of cruft in this section of nixpkgs and it could do with a cleanup...
felixsinger
force-pushed
the
add-pkgs/cups/drivers/mfc9332cdw
branch
from
cc7700d
to
71d26e4
Compare
ofborg
bot
added
8.has: package (new)
11.by: package-maintainer
10.rebuild-linux: 1-10
and removed
10.rebuild-linux: 0
labels
|
@NickHu Done. I adjusted the commit message and added the packages to all-packages.nix. Until now I wasn't aware of all-packages.nix. To build the packages I used callPackage with nix-build and I added a line to my configuration.nix to test it. |
| @@ -25948,6 +25948,9 @@ in | |||
|
|
|||
| hll2390dw-cups = callPackage ../misc/cups/drivers/hll2390dw-cups { }; | |||
|
|
|||
| mfc9332cdwcupswrapper = (callPackage ../misc/cups/drivers/brother/mfc9332cdw { }).mfc9332cdwcupswrapper; | |||
There was a problem hiding this comment.
| mfc9332cdwcupswrapper = (callPackage ../misc/cups/drivers/brother/mfc9332cdw { }).mfc9332cdwcupswrapper; | |
| mfc9332cdw-cupswrapper = (callPackage ../misc/cups/drivers/brother/mfc9332cdw { }).cupswrapper; |
to match the attribute name below
| dlfid = "dlf101642"; | ||
| relpath_wrapper = "${relpath_printer}/cupswrapper"; |
There was a problem hiding this comment.
These can probably also be moved to a let expr, like with the drv above.
| cp brcupsconfig/brcupsconfpt1 $out/${relpath_wrapper} | ||
| cp cupswrapper/cupswrapper${model} $out/${relpath_wrapper} | ||
| cp PPD/brother_${model}_printer_en.ppd $out/${relpath_wrapper} | ||
|
|
||
| # configure permissions | ||
| chmod 755 $out/${relpath_wrapper}/brcupsconfpt1 | ||
| chmod 755 $out/${relpath_wrapper}/cupswrapper${model} | ||
| chmod 644 $out/${relpath_wrapper}/brother_${model}_printer_en.ppd |
There was a problem hiding this comment.
you can use install -m … to copy these over while specifying the chmod.
There's also -D, which you might be able to use to create the directories in first place.
| dlfid = "dlf101620"; | ||
| relpath_lpd = "${relpath_printer}/lpd"; |
There was a problem hiding this comment.
move these into the above let expr, so it's more readable what other variables are available inside the mkDerivation.
|
|
||
| nativeBuildInputs = [ dpkg makeWrapper ]; | ||
|
|
||
| unpackPhase = "dpkg-deb -x $src $out"; |
There was a problem hiding this comment.
use unpackCmd instead of overriding the whole phase.
| }; | ||
| }; | ||
|
|
||
| mfc9332cdwcupswrapper = stdenv.mkDerivation rec { |
There was a problem hiding this comment.
| mfc9332cdwcupswrapper = stdenv.mkDerivation rec { | |
| cupswrapper = stdenv.mkDerivation rec { |
NickHu
changed the title
|
Hey @felixsinger, it's been a while. Are you planning to address the recommendations made by @flokli? |
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
|
Closing due to inactivity from author. |
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)