convos: init at 4.22 #88940

stigtsp · 2020-05-26T14:08:15Z

This PR add the web based IRC client convos, including nixos module and tests.

Several perlPackage dependencies are added, and some are updated.

nixos/modules/services/web-apps/convos.nix

stigtsp · 2020-06-05T11:09:30Z

Updating convos to 4.18

jhthorsen

This is awesome 👍 So glad you created this PR @stigtsp!

pkgs/applications/networking/irc/convos/default.nix

nixos/modules/services/web-apps/convos.nix

pkgs/applications/networking/irc/convos/default.nix

pkgs/top-level/perl-packages.nix

pkgs/applications/networking/irc/convos/default.nix

aanderse

I have reviewed the module. Maybe @volth wants to give a quick glance over the packages for final approval there 🤷‍♂️

Looking good though 👍

nixos/modules/services/web-apps/convos.nix

stigtsp · 2020-06-11T12:06:09Z

Thx for reviewing 👍

aanderse · 2020-06-11T13:30:05Z

nixos/modules/services/web-apps/convos.nix

+        DynamicUser = true;
+        MemoryDenyWriteExecute = true;
+        ProtectSystem = "strict";
+        ProtectHome = true;


@stigtsp at least a few of these options are already implied with DynamicUser. A quick search for DynamicUser in the systemd manual will cut a few lines here.

Yes, ProtectSystem and ProtectHome are implied and can be removed.

Thanks @talyz @aanderse :) I've removed ProtectSystem=strict.

Seems like ProtectHome=read-only is implied by DynamicUser=true according to the documentation, so keeping ProtectHome=true.

Added SystemCallFilter, SystemCallArchitectures, CapabilityBoundingSet, and some more flags highlighted by systemd-analyze security.

→ Overall exposure level for convos.service: 1.3 OK 🙂

Does this look ok?

Ah, yes, you're right :) Looks good to me, assuming all features you want still work as expected ;)

talyz · 2020-06-11T16:42:42Z

@GrahamcOfBorg test convos

stigtsp · 2020-06-17T15:02:51Z

Waiting for a new release from upstream that contains some important fixes.

talyz · 2020-06-17T15:07:45Z

@stigtsp Can you add the test to passthru.tests? That way the test is automatically run for PRs and easy to refer to. See tests here: https://nixos.org/nixpkgs/manual/#sec-standard-meta-attributes

stigtsp · 2020-06-21T18:54:44Z

This PR includes updates to perlPackages.MojoliciousPluginOpenAPI, perlPackages.JSONValidator and perlPackages.Mojolicious which are also included in #91184 I suggest merging this PR after the cpan2nix updates have been merged.

dependencies: perlPackages.IRCUtils: init at 0.12 perlPackages.LinkEmbedder: init at 1.12 perlPackages.MojoliciousPluginWebpack: init at 0.12 perlPackages.ParseIRC: init at 1.22 perlPackages.TimePiece: init at 1.3401 perlPackages.UnicodeUTF8: init at 0.62

stigtsp · 2020-06-22T12:11:46Z

Those mass updates are typically stuck for 2-3 weeks (no one wants to review them), so probably there is no point to wait.
Also that PR is against staging which merged to master every few weeks.

Ok - updated Mojolicious in this PR to 8.55, so it should be ready I hope :-) Does the perlPackages updates look ok?

Result of nixpkgs-review pr 88940 1

42 packages built:

- abcde
- convos
- perl528Packages.IRCUtils
- perl528Packages.JSONValidator
- perl528Packages.LinkEmbedder
- perl528Packages.MojoIOLoopForkCall
- perl528Packages.MojoJWT
- perl528Packages.MojoPg
- perl528Packages.MojoRedis
- perl528Packages.MojoSQLite
- perl528Packages.Mojolicious
- perl528Packages.MojoliciousPluginMail
- perl528Packages.MojoliciousPluginOpenAPI
- perl528Packages.MojoliciousPluginStatus
- perl528Packages.MojoliciousPluginTextExceptions
- perl528Packages.MojoliciousPluginWebpack
- perl528Packages.Mojomysql
- perl528Packages.MusicBrainz
- perl528Packages.OpenAPIClient
- perl528Packages.ParseIRC
- perl528Packages.TimePiece
- perl528Packages.UnicodeUTF8
- perl530Packages.IRCUtils
- perl530Packages.JSONValidator
- perl530Packages.LinkEmbedder
- perl530Packages.MojoIOLoopForkCall
- perl530Packages.MojoJWT
- perl530Packages.MojoPg
- perl530Packages.MojoRedis
- perl530Packages.MojoSQLite
- perl530Packages.Mojolicious
- perl530Packages.MojoliciousPluginMail
- perl530Packages.MojoliciousPluginOpenAPI
- perl530Packages.MojoliciousPluginStatus
- perl530Packages.MojoliciousPluginTextExceptions
- perl530Packages.MojoliciousPluginWebpack
- perl530Packages.Mojomysql
- perl530Packages.MusicBrainz
- perl530Packages.OpenAPIClient
- perl530Packages.ParseIRC
- perl530Packages.TimePiece
- perl530Packages.UnicodeUTF8

aanderse

Yeah this looks good to me from a quick overview. @talyz I think we should merge... agree?

talyz

@aanderse Yep, looks good to me 👍

talyz · 2020-06-25T07:35:34Z

@stigtsp Thanks for doing this! Great work! 🎉

stigtsp · 2020-06-25T08:31:01Z

Thx for the reviews and advice, everyone :)

FRidh · 2020-06-26T08:28:50Z

Fixed eval in cd8e099.

stigtsp requested review from volth and etu May 26, 2020 14:08

ofborg bot added 6.topic: nixos 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 labels May 26, 2020

stigok approved these changes May 26, 2020

View reviewed changes

nixos/modules/services/web-apps/convos.nix Outdated Show resolved Hide resolved

fnords approved these changes May 27, 2020

View reviewed changes

stigtsp requested a review from aanderse June 5, 2020 11:04

stigtsp force-pushed the package/convos-init branch from 4cf88ca to b4fab0f Compare June 5, 2020 12:57

stigtsp changed the title ~~convos: init at 4.12~~ convos: init at 4.18 Jun 5, 2020

stigtsp mentioned this pull request Jun 5, 2020

Build installable packages convos-chat/convos#491

Closed

jhthorsen reviewed Jun 6, 2020

View reviewed changes

stigtsp force-pushed the package/convos-init branch 2 times, most recently from 201e4a7 to 51ecd4e Compare June 9, 2020 17:42

jhthorsen reviewed Jun 10, 2020

View reviewed changes

pkgs/applications/networking/irc/convos/default.nix Outdated Show resolved Hide resolved

stigtsp force-pushed the package/convos-init branch from 51ecd4e to 7d19cc0 Compare June 11, 2020 06:21

stigtsp changed the title ~~convos: init at 4.18~~ convos: init at 4.19 Jun 11, 2020

stigtsp force-pushed the package/convos-init branch from 7d19cc0 to 384e35d Compare June 11, 2020 06:28

stigtsp requested a review from talyz June 11, 2020 06:33

stigtsp force-pushed the package/convos-init branch from 384e35d to b19c0b7 Compare June 11, 2020 07:17

aanderse requested changes Jun 11, 2020

View reviewed changes

stigtsp force-pushed the package/convos-init branch from b19c0b7 to 4115ddf Compare June 11, 2020 12:04

aanderse reviewed Jun 11, 2020

View reviewed changes

stigtsp force-pushed the package/convos-init branch from 4115ddf to 8e7faf8 Compare June 11, 2020 14:55

stigtsp marked this pull request as draft June 17, 2020 15:02

stigtsp force-pushed the package/convos-init branch 3 times, most recently from ce47b04 to 509bac5 Compare June 21, 2020 18:43

stigtsp changed the title ~~convos: init at 4.19~~ convos: init at 4.22 Jun 21, 2020

stigtsp added 7 commits June 22, 2020 13:56

perlPackages.Mojolicious: 8.32 -> 8.55

dbda655

perlPackages.Mojolicious: add sgo to maintainers

1fecbbc

perlPackages.JSONValidator: 3.23 -> 4.00

15f889d

perlPackages.MojoliciousPluginOpenAPI: 2.21 -> 3.33

e755287

convos: init at 4.22

497ac5b

dependencies: perlPackages.IRCUtils: init at 0.12 perlPackages.LinkEmbedder: init at 1.12 perlPackages.MojoliciousPluginWebpack: init at 0.12 perlPackages.ParseIRC: init at 1.22 perlPackages.TimePiece: init at 1.3401 perlPackages.UnicodeUTF8: init at 0.62

nixos/convos: init

042a2d8

nixos/convos: add test

a71fd5c

stigtsp force-pushed the package/convos-init branch from 509bac5 to a71fd5c Compare June 22, 2020 12:04

stigtsp marked this pull request as ready for review June 22, 2020 12:11

stigtsp requested a review from aanderse June 24, 2020 19:08

aanderse approved these changes Jun 24, 2020

View reviewed changes

talyz approved these changes Jun 25, 2020

View reviewed changes

talyz merged commit c00bf08 into NixOS:master Jun 25, 2020

FRidh mentioned this pull request Jun 26, 2020

Evaluation check does not consider passthru and thus passthru.tests NixOS/ofborg#524

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

convos: init at 4.22 #88940

convos: init at 4.22 #88940

stigtsp commented May 26, 2020 •

edited

stigtsp commented Jun 5, 2020

jhthorsen left a comment

aanderse left a comment

stigtsp commented Jun 11, 2020

aanderse Jun 11, 2020

talyz Jun 11, 2020

stigtsp Jun 11, 2020

talyz Jun 11, 2020

talyz commented Jun 11, 2020

stigtsp commented Jun 17, 2020

talyz commented Jun 17, 2020

stigtsp commented Jun 21, 2020

stigtsp commented Jun 22, 2020 •

edited

aanderse left a comment

talyz left a comment

talyz commented Jun 25, 2020

stigtsp commented Jun 25, 2020

FRidh commented Jun 26, 2020

convos: init at 4.22 #88940

convos: init at 4.22 #88940

Conversation

stigtsp commented May 26, 2020 • edited

stigtsp commented Jun 5, 2020

jhthorsen left a comment

Choose a reason for hiding this comment

aanderse left a comment

Choose a reason for hiding this comment

stigtsp commented Jun 11, 2020

aanderse Jun 11, 2020

Choose a reason for hiding this comment

talyz Jun 11, 2020

Choose a reason for hiding this comment

stigtsp Jun 11, 2020

Choose a reason for hiding this comment

talyz Jun 11, 2020

Choose a reason for hiding this comment

talyz commented Jun 11, 2020

stigtsp commented Jun 17, 2020

talyz commented Jun 17, 2020

stigtsp commented Jun 21, 2020

stigtsp commented Jun 22, 2020 • edited

aanderse left a comment

Choose a reason for hiding this comment

talyz left a comment

Choose a reason for hiding this comment

talyz commented Jun 25, 2020

stigtsp commented Jun 25, 2020

FRidh commented Jun 26, 2020

stigtsp commented May 26, 2020 •

edited

stigtsp commented Jun 22, 2020 •

edited