Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shen-sbcl: init at 3.0.3 #88915

Merged
merged 5 commits into from Sep 8, 2020
Merged

shen-sbcl: init at 3.0.3 #88915

merged 5 commits into from Sep 8, 2020

Conversation

bsima
Copy link
Contributor

@bsima bsima commented May 26, 2020

Motivation for this change

I wanted to use shen on NixOS.

Related to Shen-Language/shen-cl#50

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bsima
Copy link
Contributor Author

bsima commented May 26, 2020

I named the output binary of the shen-sbcl package as shen-sbcl because I plan to also add shen-chez and shen-haskell and shen-rust and whatever else I can.

@bsima
Copy link
Contributor Author

bsima commented May 26, 2020

Force pushed with license information

@tizoc
Copy link

tizoc commented May 29, 2020

@bsima do you need help testing this in OSX ?

@tizoc
Copy link

tizoc commented May 29, 2020

FYI, I was able to successfully build the shen-sbcl package under OSX

bash-3.2$ export NIXPKGS_ALLOW_UNSUPPORTED_SYSTEM=1
bash-3.2$ nix-build -A shen-sbcl
# ...... snip ......
patching script interpreter paths in /nix/store/cqb82sl7yfr0yag7a73j9c5rmxcd34i6-shen-sbcl-3.0.3
/nix/store/cqb82sl7yfr0yag7a73j9c5rmxcd34i6-shen-sbcl-3.0.3
bash-3.2$ result/bin/shen-sbcl 

Shen, copyright (C) 2010-2015 Mark Tarver
www.shenlanguage.org, Shen 22.2
running under Common Lisp, implementation: SBCL
port 3.0.3 ported by Mark Tarver, Robert Koeninger and Bruno Deferrari
exit REPL with (cl.exit)

(0-) 

@bsima
Copy link
Contributor Author

bsima commented May 29, 2020

FYI, I was able to successfully build the shen-sbcl package under OSX

Cool, I suppose that means we can say that shen-sbcl supports any platform that sbcl supports.

And shen-sources should be supportable on all platforms, since it's just the text files.

@tizoc
Copy link

tizoc commented May 29, 2020

@bsima yes. And for the record, I develop primarily on OSX. Both Shen/SBCL and Shen/Scheme run without problems. The binary releases are built and tested by a Travis-CI job that runs on Windows, Linux and OSX virtual machines.

@marsam marsam changed the title Add Shen shen-sbcl: init at 3.0.3 Sep 8, 2020
@marsam marsam merged commit ee222ce into NixOS:master Sep 8, 2020
@marsam
Copy link
Contributor

marsam commented Sep 8, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants