Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pinnwand: init at 1.1.0 #88995

Merged
merged 2 commits into from May 27, 2020
Merged

pinnwand: init at 1.1.0 #88995

merged 2 commits into from May 27, 2020

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented May 27, 2020 •
edited

Motivation for this change

A Python pastebin that tries to keep it simple. https://supakeen.com/project/pinnwand

https://github.com/supakeen/pinnwand

This is the pastebin software used at https://bpa.st/.

Had to introduce tornado_6 and<&s> package pygments-better-html (has no tests) as dependencies.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jonringer
jonringer reviewed May 27, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

pkgs/development/python-modules/pygments-better-html/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pygments-better-html/default.nix Show resolved Hide resolved
@jonringer
Copy link
Contributor

jonringer commented May 27, 2020 •
edited

is this the only package which needs tornado 6? I would prefer to remove pinning from python_modules, as it can make incoherent environments.

please move the pinning into the application expressions, aws-cli is an example of how to do this.

edit. I glanced over this in the first review, sorry

@mweinelt
Copy link
Member Author

Yeah, currently this is the only package needing tornado 6, so I added the overwrite into the application expression.

jonringer
jonringer approved these changes May 27, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 88995 1

3 packages built:
- pinnwand
- python37Packages.pygments-better-html
- python38Packages.pygments-better-html

@jonringer jonringer merged commit c2e8ea4 into NixOS:master May 27, 2020
@mweinelt mweinelt deleted the pinnwand branch May 27, 2020 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mweinelt @jonringer