Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deepin.{go-dbus-generator;dbus-factory}: remove #88954

Merged
merged 2 commits into from May 27, 2020
Merged

deepin.{go-dbus-generator;dbus-factory}: remove #88954

merged 2 commits into from May 27, 2020

Conversation

romildo
Copy link
Contributor

@romildo romildo commented May 26, 2020 •
edited

Motivation for this change

They have been archived upstream and no other package really depends on them.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cole-h
cole-h requested changes May 26, 2020
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

$ rg 'go-dbus-generator'
pkgs/desktops/deepin/dbus-factory/default.nix
5:, go-dbus-generator
23:    go-dbus-generator

Looks like you missed a reverse dependency.

@romildo
deepin.go-dbus-generator: remove
7dbf35e 
It has been archived upstream and no other package currently depends
on it.
@romildo
deepin.dbus-factory: remove
5863654 
It is not really needed by the other packages.
@romildo romildo changed the title deepin.go-dbus-generator: remove deepin.{go-dbus-generator;dbus-factory}: remove May 26, 2020
@romildo
Copy link
Contributor Author

romildo commented May 26, 2020

@cole-h I have not seen your suggestion of change. I have pushed more changes and when I came back your suggestion was not available anymore.

dbus-factory is being removed too.

@romildo
Copy link
Contributor Author

romildo commented May 26, 2020

Result of nixpkgs-review pr 88954 1

12 packages built:
- deepin.dde-api
- deepin.dde-control-center
- deepin.dde-daemon
- deepin.dde-dock
- deepin.dde-file-manager
- deepin.dde-kwin
- deepin.dde-launcher
- deepin.dde-session-ui
- deepin.deepin-desktop-base
- deepin.deepin-desktop-schemas
- deepin.deepin-wallpapers
- deepin.startdde

cole-h
cole-h approved these changes May 26, 2020
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only suggestion was that something else depended on dbus-factory (still visible above, at least for me), which was breaking evaluation. Since that's getting removed, looks good now!

@romildo romildo merged commit b3e3a45 into NixOS:master May 27, 2020
@romildo romildo deleted the upd.go-dbus-generator branch May 27, 2020 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cole-h cole-h cole-h approved these changes

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@romildo @cole-h