Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

joplin-desktop: 1.0.201 -> 1.0.216 #88922

Merged
merged 2 commits into from May 28, 2020
Merged

joplin-desktop: 1.0.201 -> 1.0.216 #88922

merged 2 commits into from May 28, 2020

Conversation

CheariX
Copy link
Contributor

@CheariX CheariX commented May 26, 2020 •
edited

Motivation for this change

New Release.

  • Take care: WYSIWYG Editor is now default. Use Code-View Button on top bar.
  • First start upgrades Database - impossible to go back.
    • If you simply want to test this version, create a Backup ("File -> Export -> JEX") before you upgrade
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from HugoReeves and raquelgb May 26, 2020 08:17
@HugoReeves
Copy link
Member

I'm not able to test the build currently but LGTM. Thanks

@ajs124
Copy link
Member

ajs124 commented May 26, 2020 

* impossible to go back.

If you have it synchronized to a server, you can throw away your config and start over, with an older version.

@CheariX
Copy link
Contributor Author

CheariX commented May 27, 2020 •
edited

Yes. It might be even easier to use Joplins Backup-and-Restore functions.
This remark is just for people who want to quickly verify this PR and then go back.
(Actually, it was you who took my attention to this fact)

@HugoReeves
Copy link
Member

@CheariX could you please remove rafaelgg raquelgb from the maintainers section. Both users have been inactive on GitHub, I pinged raquel in the last two PRs and received no response. By removing them, future PRs will be assigned a different reviewer. Pinging @raquelgb to check if they still aren't responding.

@HugoReeves
Copy link
Member

Once that's done I'll try to contact someone with merge rights to get this merged.

@CheariX
Copy link
Contributor Author

CheariX commented May 28, 2020

Thanks. I've just updated the branch.

@ofborg ofborg bot requested a review from HugoReeves May 28, 2020 11:48
@infinisil infinisil merged commit f5859e6 into NixOS:master May 28, 2020
@CheariX CheariX deleted the joplin-desktop-1.0.216 branch May 29, 2020 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HugoReeves HugoReeves HugoReeves approved these changes

@raquelgb raquelgb Awaiting requested review from raquelgb

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@CheariX @HugoReeves @ajs124 @infinisil