Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nomacs/maintainer change #88957

Merged
merged 3 commits into from May 26, 2020
Merged

Nomacs/maintainer change #88957

merged 3 commits into from May 26, 2020

Conversation

Mindavi
Copy link
Contributor

@Mindavi Mindavi commented May 26, 2020

Motivation for this change

The maintainer of nomacs asked me to take over maintenance, since I've updated the package a short while ago. I'm okay with that. See the commit message for the email contents.

I've also taken the liberty to remove his name from the maintainers list, because he told me he's not using NixOS (or Nix) anymore. This leaves some packages without maintainer, but so be it. At least it's clear now that he won't do it anymore.

Also, I missed a patch that I've removed from the default.nix but was still present in the folder (see #87933), so that's removed now.

cc @ahmedtd (the old maintainer)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mindavi
nomacs: remove old maintainer, add myself as maintainer
7042530 
The old maintainer @ahmedtd sent me the following email:

Title: Are you interested in being the NixPkgs maintainer for nomacs?
Body: I don't run NixOS anymore, so I can't really build or check the PRs.
@Mindavi
maintainers: remove @ahmedtd
0cf8e1d
@Mindavi
nomacs: remove unused patch
5b32225 
This patch became obsolete in the previous update, so can be removed.
@ahmedtd
Copy link
Contributor

ahmedtd commented May 26, 2020

LGTM, thanks!

@veprbl veprbl merged commit 7a36742 into NixOS:master May 26, 2020
@Mindavi Mindavi deleted the nomacs/maintainer-change branch May 26, 2020 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mindavi @ahmedtd @veprbl