Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ardour: add ardour 6 and make it the default #88950

Closed
wants to merge 1 commit into from
Closed

ardour: add ardour 6 and make it the default #88950

wants to merge 1 commit into from

Conversation

magnetophon
Copy link
Member

@magnetophon magnetophon commented May 26, 2020 •
edited

We leave Ardour 5 in, since Ardour 6 has a new latency compensation
algorithm, so your mixes might end up sounding different in the new version.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@x42
Copy link

x42 commented May 26, 2020

looks like you've missed libpulse-dev and libwebsockes-dev packages as dependency

@magnetophon
Copy link
Member Author

magnetophon commented May 26, 2020 •
edited

looks like you've missed libpulse-dev and libwebsockes-dev packages as dependency

@x42
pulseaudio is in there,and it claims to build with it. I don't have pulse installed,so have not tested.

seems that in order to build with libwebsockets, you also need libuv (assuming that's what provides uv.h), but it only fails halfway trough the build.
Both are in now, thanks.

@ofborg ofborg bot requested a review from cillianderoiste May 26, 2020 20:24
veprbl
veprbl reviewed May 26, 2020
View reviewed changes
pkgs/applications/audio/ardour/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/ardour/default.nix Outdated Show resolved Hide resolved
@prusnak
Copy link
Member

prusnak commented May 26, 2020 •
edited

I made an earlier PR here: #87274 - Please make sure you cherry-pick all of the changes from my PR that you want to include. I will close my PR in favor of this one afterward.

Also it's always a good idea to check for other PRs, before starting your own, to avoid duplicate work.

@magnetophon
Copy link
Member Author

magnetophon commented May 26, 2020 •
edited

@prusnak Oh,I thought I had checked for other PRs, sorry!
I incorporated most of your changes, but yours has the same issue as @veprbl 's: it replaces ardour5 when installing 6, which what I wanted to avoid, see the commit message about the new latency compensation.
What do you suggest?

@veprbl
Copy link
Member

veprbl commented May 27, 2020

@magnetophon Forgot to push the updated commits?

@magnetophon
Copy link
Member Author

@veprbl Ah, yes, something went wrong.

prusnak
prusnak requested changes May 27, 2020
View reviewed changes
pkgs/applications/audio/ardour/5.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/ardour/5.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/ardour/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/ardour/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/ardour/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/ardour/default.nix Outdated Show resolved Hide resolved
@prusnak prusnak mentioned this pull request May 27, 2020
Closed
10 tasks
@magnetophon magnetophon force-pushed the ardour branch 2 times, most recently from 1d9c1b7 to d936550 Compare May 27, 2020 14:56
@veprbl veprbl self-assigned this May 27, 2020
veprbl
veprbl approved these changes May 27, 2020
View reviewed changes
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a few minor comments.

pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/ardour/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/ardour/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/ardour/default.nix Outdated Show resolved Hide resolved
@veprbl veprbl removed their assignment May 27, 2020
@magnetophon
Copy link
Member Author

@veprbl Thanks, all done.

@magnetophon
ardour: add ardour 6 and make it the default
973b838 
We leave Ardour 5 in, since Ardour 6 has a new latency compensation
algorithm, so your mixes might end up sounding different in the new version.
@magnetophon magnetophon deleted the ardour branch May 29, 2020 13:52
@magnetophon
Copy link
Member Author

Something went wrong here, I'm trying to fix it!

@magnetophon magnetophon mentioned this pull request May 29, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@x42 x42 x42 left review comments

@cole-h cole-h cole-h left review comments

@prusnak prusnak prusnak approved these changes

@veprbl veprbl veprbl approved these changes

@cillianderoiste cillianderoiste Awaiting requested review from cillianderoiste

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@magnetophon @x42 @prusnak @veprbl @cole-h