Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

powerdevil: add DDC support #88942

Merged
merged 2 commits into from May 28, 2020
Merged

powerdevil: add DDC support #88942

merged 2 commits into from May 28, 2020

Conversation

peterhoeg
Copy link
Member

Motivation for this change

This allows you to control the monitor brightness for external monitors
using the plasma "Battery & Brightness" control on desktop
computers.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@peterhoeg peterhoeg requested a review from ttuegel as a code owner May 26, 2020 14:34
@peterhoeg
Copy link
Member Author

@GrahamcOfBorg build tests.plasma5

@peterhoeg peterhoeg merged commit ad0df84 into NixOS:master May 28, 2020
@peterhoeg peterhoeg deleted the m/kde_ddc branch May 28, 2020 11:14
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/brightness-control-of-external-monitors-with-ddcci-backlight/8639/3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel ttuegel approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 6.topic: qt/kde 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@peterhoeg @nixos-discourse @ttuegel