Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MuPDF: 1.16.1 -> 1.17, PyMuPDF: 1.16.18 -> 1.17.0, llpp: v31 -> v32, zathura: patch for muPDF 1.17 #88919

Merged
merged 4 commits into from Jun 6, 2020
Merged

MuPDF: 1.16.1 -> 1.17, PyMuPDF: 1.16.18 -> 1.17.0, llpp: v31 -> v32, zathura: patch for muPDF 1.17 #88919

merged 4 commits into from Jun 6, 2020

Conversation

wamserma
Copy link
Member

@wamserma wamserma commented May 26, 2020 •
edited

Motivation for this change

MuPDF version bump including downstream updates due to API changes. Bundled in a single PR to avoid intermediate breakage on master.

Supersedes/Includes #87238

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review pr 88919"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

r-ryantm and others added 2 commits May 26, 2020 08:26
@r-ryantm @wamserma
mupdf: 1.16.1 -> 1.17.0
c2e576b 
(cherry picked from commit f51b593)
@wamserma
pythonPackages.PyMuPDF: 1.16.18 -> 1.17.0
b20b08d 
Update for compatibility with MuPDF 1.17
@ofborg ofborg bot requested review from fpletz, teto and vrthra May 26, 2020 06:48
@wamserma wamserma changed the title MuPDF: 1.16.1 -> 1.17, PyMuPDF: 1.16.18 -> 1.17.0 MuPDF: 1.16.1 -> 1.17, PyMuPDF: 1.16.18 -> 1.17.0, llpp: v31 -> v32, zathura: patch for muPDF 1.17 Jun 6, 2020
@wamserma wamserma marked this pull request as ready for review June 6, 2020 11:56
@ofborg ofborg bot requested review from pSub and Enzime June 6, 2020 11:58
@teto
Copy link
Member

teto commented Jun 6, 2020 

[22 built, 61 copied (1533.0 MiB), 477.2 MiB DL]
https://github.com/NixOS/nixpkgs/pull/88919
13 packages built:
cups-filters jfbpdf jfbview k2pdfopt llpp mupdf python27Packages.pymupdf python37Packages.pymupdf python38Packages.pymupdf splix system-config-printer termpdfpy zathura

@teto teto merged commit e63c8c4 into NixOS:master Jun 6, 2020
@wamserma wamserma mentioned this pull request Jun 6, 2020
Closed
@wamserma wamserma deleted the mupdf-1.17 branch June 6, 2020 16:18
@wamserma wamserma mentioned this pull request Oct 13, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz Awaiting requested review from fpletz

@teto teto Awaiting requested review from teto

@vrthra vrthra Awaiting requested review from vrthra

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@pSub pSub Awaiting requested review from pSub

@Enzime Enzime Awaiting requested review from Enzime

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wamserma @teto @r-ryantm