Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1password: 0.10.0 -> 1.0.0 #88933

Merged
merged 1 commit into from Jun 8, 2020
Merged

1password: 0.10.0 -> 1.0.0 #88933

merged 1 commit into from Jun 8, 2020

Conversation

knl
Copy link
Contributor

@knl knl commented May 26, 2020 •
edited

Motivation for this change

From their release notes:

In this release, we add the ability to choose which fields are returned by "get item". When a single field is requested, its data is returned as a simple string. For multiple fields, data is returned in a JSON object or in CSV format.

New:

  • You can specify which fields are returned by "get item" with the "--fields" and "--format" flags.
  • You can customize the "--generate-password" option for "create/edit item". Use a password recipe to specify the length and characters included.

Improvements:

  • Using "reactivate" on an active user no longer returns an error.
  • Various error messages have been clarified.

Fixed:

  • Fixed a panic caused by using "--shorthand" when signing in after the first time.
  • Fixed problem where session files could become corrupted when running multiple "op" commands concurrently.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@knl knl requested review from marsam and joelburget May 26, 2020 10:46
@Lassulus
Copy link
Member

Lassulus commented Jun 4, 2020

getting this error:

$ nix build --no-link --keep-going --option build-use-sandbox relaxed -f /home/lass/.cache/nixpkgs-review/pr-88933/build.nix
warning: ignoring the user-specified setting 'sandbox', because it is a restricted setting and you are not a trusted user
hash mismatch in fixed-output derivation '/nix/store/rpbb5nc1z9q4csicdjd827am1j2vgbvg-source':
  wanted: sha256:00w1ywjg4bmh2dw3099fwswjr29zwfx2sjgqa8djfiaji49gwxcf
  got:    sha256:0pscm61dc69vmkrzrnxi531d37ig9y48w8q1lvzsg13zvvwaw8hs
cannot build derivation '/nix/store/nhqsxs98m2fxk0lfg4v32yb92hxdbl4j-1password-1.0.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/fsf5rwnyg4df0afsbrnp01iyafkwbs9v-env.drv': 1 dependencies couldn't be built

@knl
Copy link
Contributor Author

knl commented Jun 7, 2020

@Lassulus I downloaded the linux file from their website, and this is the hash I'm getting:

$ nix-hash --type sha256 --flat --base32 ~/Downloads/op_linux_amd64_v1.0.0.zip
00w1ywjg4bmh2dw3099fwswjr29zwfx2sjgqa8djfiaji49gwxcf

I tried downloading the file again, the hash remains the same.

When I try to build the package on Linux, I'm getting the very same error.

@knl knl force-pushed the bump-1password-to-1.0.0 branch from c11e97b to 5c5afa6 Compare June 7, 2020 18:09
@knl knl force-pushed the bump-1password-to-1.0.0 branch from 5c5afa6 to 00ec55d Compare June 7, 2020 18:16
@knl
Copy link
Contributor Author

knl commented Jun 7, 2020

Silly me... Linux variants use fetchzip, while darwin has fetchurl, due to needing to unpack a .pkg file. For fetchzip, one needs the shasum of the unpacked content. I updated the SHAs to match.

@Lassulus Lassulus merged commit 1701285 into NixOS:master Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam Awaiting requested review from marsam

@joelburget joelburget Awaiting requested review from joelburget

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@knl @Lassulus