Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zerofree: install manpage and COPYING file #88927

Merged
merged 1 commit into from Feb 4, 2021
Merged

zerofree: install manpage and COPYING file #88927

merged 1 commit into from Feb 4, 2021

Conversation

Moredread
Copy link
Contributor

@Moredread Moredread commented May 26, 2020 •
edited

Motivation for this change

Install COPYING and manpage from Debian/Ubuntu.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from ctheune May 26, 2020 09:06
@stale
Copy link

stale bot commented Nov 22, 2020

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 22, 2020
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 23, 2020
@SuperSandro2000
Copy link
Member

@Moredread please resolve the merge conflict.

@Moredread
Copy link
Contributor Author

@SuperSandro2000 there is no official page for this package. Alternatively we could maybe add a ubuntu-manpages and debian-manpages derivation and link from those. I'm not sure though how large the man pages are that are provided by Debian and Ubuntu and if we want to add a large dependency only for the man page.

Maybe this is a larger issue... When I get around to it I'll write something up und Discourse.

Are you still interested in this PR?

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 20, 2021 •
edited

Are you still interested in this PR?

I am not personally interested in most PRs. If you think this is a good addition go for it.

@jtojnar
Copy link
Contributor

jtojnar commented Jan 20, 2021

Alternately, you could try to work with upstream and get it to accept the manpage from Debian. We did that for other packages successfully in the past (example).

@Moredread
Copy link
Contributor Author

I've resolved the merge conflict.

@SuperSandro2000 SuperSandro2000 merged commit 6dac157 into NixOS:master Feb 4, 2021
@Moredread Moredread deleted the zerofree-manpage branch February 5, 2021 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@ctheune ctheune Awaiting requested review from ctheune

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Moredread @SuperSandro2000 @jtojnar