Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: an option to indicate the first entry in BaseGraphics listing #22

Merged
merged 1 commit into from May 26, 2020

Conversation

TrueBrain
Copy link
Member

OpenTTD client's bootstrap implementation downloads what-ever is
the first entry of the BaseGraphics listing. Without this, this
strongly depends on the order of listdir(), but rarely is OpenGFX,
which we prefer. Of course this can be considered a bug in OpenTTD
client, but for now we can fix this by adding an option that forces
a predefined unique-id to be the first in the list. In production
this will of course be OpenGFX.

OpenTTD client's bootstrap implementation downloads what-ever is
the first entry of the BaseGraphics listing. Without this, this
strongly depends on the order of listdir(), but rarely is OpenGFX,
which we prefer. Of course this can be considered a bug in OpenTTD
client, but for now we can fix this by adding an option that forces
a predefined unique-id to be the first in the list. In production
this will of course be OpenGFX.
@TrueBrain TrueBrain changed the title Add: allow an option what the first package is for BaseGraphics listing Add: an option to indicate the first entry in BaseGraphics listing May 26, 2020
Copy link

@nielsmh nielsmh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me

@TrueBrain TrueBrain merged commit fbe4ba7 into OpenTTD:master May 26, 2020
@TrueBrain TrueBrain deleted the fix_bootstrap branch May 26, 2020 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants