This should close #88903 and navidrome/navidrome#209

However I can't "approve" them in github

You can apply the changes manually in your fork.

You can apply the changes manually in your fork.

I pushed the commit with the new version and your suggested changes to my fork but at the beginning of this page, in the tab "commits" I can see only the initial commit.
Sorry for the stupid questions but this is my fist time doing these things, and thank you for reviewing this PR.

Edit: problem solved, I was pushing to the master branch of my fork, insted of the navidrome branch.

This has not been fixed

@prusnak I updated to 0.23.0 but I can't understand the last two changes you suggested four days ago, aren't they already resolved?
I mean this and this.

aren't they already resolved?

No they are not. See https://github.com/NixOS/nixpkgs/pull/88928/files

No they are not. See https://github.com/NixOS/nixpkgs/pull/88928/files

@prusnak Now I marked as resolved all the changes in thae page you link. However I'm not sure to understand what you mean.
You can see here that the description, homepage, license and platforms fields are correct (as your suggested changes of 4 days ago).

fields are correct

No, they are not.

From your file:

license = stdenv.lib.licenses.gpl3;
platforms = platforms.x86_64;

My suggestions (you marked as resolved but you did not apply them):

license = licenses.gpl3;
platforms = [ "x86_64-linux" ];

@prusnak Ahhh, I feel so stupid, forgive me, this is my first pull request on Github and I don't know all of these mechanisms. Thank you for the patience.

I thought that the green text meant it was fine

Now can my request be merged?

@acieri Oops, in the first point I wrote rebase but I meant reset, sorry. Try this:

• git rebase -i HEAD~6 (this time for real), a text editor will open
• at the top of the file, delete the lines of the other 4 commits, save and exit.
• git push --force origin

@deluan Hi, I don't think it will work just like that: npm will probably try to access the internet and Nix forbids that (it would not be reproducible). If I'm right a solution would be to add node_modules to the release tarball. This is what gitea does, which was in a similar situation.

@rnhmjoj Releasing the node_modules used to build Navidrome's UI would be straightforward, but I don't see the advantage of downloading a huge tarball (445M uncompressed) to build a JS bundle of only 6.5M (uncompressed). Why not just download the JS bundle instead? What is the advantage of building this bundle during install time

Adding to that, building the GoLang server would also require downloading all libraries (go modules) used by the project from the Internet. I fail to see how this is different from what npm does...

Sorry if these may sound naive and even dumb questions, as this is my first contact with NixOS, and I don't know anything about its philosophy and how things work around here :)

And this is probably not the best place to discuss these things... :P

Why not just download the JS bundle instead?

Sure, that would also work and save bandwidth too. If you can, this looks like a better idea.

I fail to see how this is different from what npm does...

The only difference is that there is infrastructure in Nixpkgs that can handle this automatically: basically Nix gathers all the go modules required, computes a single hash and store them in a content-addressed location that can be passed to the package builder.

There is something similar for node also: it's more involved and produces tons of generated Nix expressions, so it's not great but works. I wouldn't known how to mix the two in a single build system, though.

Sorry if these may sound naive and even dumb questions

No, don't worry. It's nice of you to stop by and helping. Thank you.

@rnhmjoj ok, I've made a terrible mess but now the git tree should be clean.

Anyway I've added the ffmpeg dependency as done in the youtube-dl derivation, it's the first package using ffmpeg that came to my mind.

However I remember that wen I tried to write the derivation using buildGoModule (or buildGoPackage?) I had the problem that npm needed the network connectivity, as you are saying.

i think that now the PR should be ready to be merged.

I accidentally closed the PR when I deleted all the commits in my fork, now I reopened it.
I did as you told me and I divided the procedure into different phases, and checked that the output file is a shell script.

Thank you!