Make --no-allow-import-from-derivation configurable in hydra-eval-jobset #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edolstra
reviewed
May 27, 2020
When deploying Hydra different than hydra.nixos.org one may encounter a problem as building any job that uses IFD fails with: May 22 19:41:07 hydra hydra-evaluator[6960]: error: "attempted to realize '/nix/store/1jm02mfiv58rpy8zrx95cpqxzsp64ssh-source.drv' during evaluation but 'allow-import-from-derivation' is false" May 22 19:41:07 hydra hydra-evaluator[6960]: error: "attempted to realize '/nix/store/av3jr8ix4qcadq2wm3y3hplvxwzlhl4y-source.drv' during evaluation but 'allow-import-from-derivation' is false" May 22 19:41:07 hydra hydra-evaluator[6960]: error: "attempted to realize '/nix/store/2jm02mfiv58rpy8zrx95cpqxzsp64ssh-source.drv' during evaluation but 'allow-import-from-derivation' is false" The recent change enforced passing `--no-allow-import-from-derivation` to `hydra-eval-job` unconditionally. This change makes it configurable and defaults to **NOT PASSING IT** -- most of the deployments allow IFDs. The configuration option is called `allow_import_from_derivation` and defaults to `true`. It is interpreted as a boolean, with only true option being `true`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deploying Hydra different than hydra.nixos.org one may encounter a problem
as building any job that uses IFD fails with:
The recent change enforced passing
--no-allow-import-from-derivationto
hydra-eval-jobunconditionally. This change makes it configurable anddefaults to NOT PASSING IT -- most of the deployments allow IFDs.
The configuration option is called
allow_import_from_derivationanddefaults to
true. It is interpreted as a boolean, with only true option beingtrue.