Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

graphql_ppx: init at 0.7.1 #88931

Merged
merged 1 commit into from Jun 9, 2020
Merged

graphql_ppx: init at 0.7.1 #88931

merged 1 commit into from Jun 9, 2020

Conversation

jtcoolen
Copy link
Member

@jtcoolen jtcoolen commented May 26, 2020 •
edited

Motivation for this change

GraphQL PPX rewriter for Bucklescript/ReasonML written in ReasonML.
See: https://github.com/reasonml-community/graphql_ppx

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtcoolen jtcoolen requested a review from vbgl May 26, 2020 10:16
Zimmi48
Zimmi48 approved these changes May 26, 2020
View reviewed changes
Copy link
Member

@Zimmi48 Zimmi48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

pkgs/development/ocaml-modules/graphql_ppx/default.nix Outdated
homepage = "https://github.com/reasonml-community/graphql_ppx";
description = "GraphQL PPX rewriter for Bucklescript/ReasonML";
license = lib.licenses.bsd3;
maintainers = [ lib.maintainers.jtcoolen ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also add me to the maintainers.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@vbgl
Copy link
Contributor

vbgl commented May 31, 2020

@GrahamcOfBorg build ocamlPackages.graphql_ppx

@vbgl
Copy link
Contributor

vbgl commented May 31, 2020

Tests failed in CI on Aarch. Is this expected?

@Zimmi48
Copy link
Member

Zimmi48 commented May 31, 2020

This package isn't documented as not working on Aarch, but on the other hand, given that native OCaml/ReasonML support was added only relatively recently, it isn't surprising that it wasn't tested on this architecture before. What do you suggest we do? Is it common for an OCaml package to fail to run correctly on this particular architecture?

@vbgl
Copy link
Contributor

vbgl commented Jun 7, 2020

What do you suggest we do?

Disable tests for that architecture.

@jtcoolen
Copy link
Member Author

jtcoolen commented Jun 8, 2020

Let's disable the tests altogether, as they mainly check for regressions.

@Zimmi48
Copy link
Member

Zimmi48 commented Jun 8, 2020

@GrahamcOfBorg build ocamlPackages.graphql_ppx

@vbgl vbgl merged commit 115b7d9 into NixOS:master Jun 9, 2020
@jtcoolen jtcoolen deleted the graphql_ppx branch June 9, 2020 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anmonteiro anmonteiro anmonteiro approved these changes

@Zimmi48 Zimmi48 Zimmi48 approved these changes

@vbgl vbgl Awaiting requested review from vbgl

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jtcoolen @vbgl @Zimmi48 @anmonteiro