Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rshijack: init at 0.3.0 #85343

Merged
merged 1 commit into from Apr 19, 2020
Merged

rshijack: init at 0.3.0 #85343

merged 1 commit into from Apr 19, 2020

Conversation

xrelkd
Copy link
Contributor

@xrelkd xrelkd commented Apr 16, 2020

Motivation for this change

TCP connection hijacker, Rust rewrite of shijack

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@marsam marsam merged commit 1406d8b into NixOS:master Apr 19, 2020
@xrelkd
Copy link
Contributor Author

xrelkd commented Apr 20, 2020

@marsam Thank you!!

@xrelkd xrelkd deleted the add/rshijack branch April 20, 2020 00:16
@xrelkd
Copy link
Contributor Author

xrelkd commented Apr 20, 2020

Added a network sniffer for #81418 (cc @JoshuaFern)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xrelkd @marsam