Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yubioath-desktop: 5.0.2 -> 5.0.3 #85303

Merged
merged 1 commit into from May 11, 2020
Merged

yubioath-desktop: 5.0.2 -> 5.0.3 #85303

merged 1 commit into from May 11, 2020

Conversation

rissson
Copy link
Member

@rissson rissson commented Apr 15, 2020 •
edited

Motivation for this change

Adds support for the Yubikey 5 NFC

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from Mic92 April 15, 2020 14:27
@rissson
Copy link
Member Author

rissson commented May 11, 2020

This is ready to merged. Any news?

@Mic92 Mic92 merged commit b535210 into NixOS:master May 11, 2020
@rissson rissson deleted the pkgs-update-yubioath-desktop branch May 11, 2020 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rissson @Mic92