trivial-builders: Sanitize derivation name #85255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This then supports using functions like writeShellScriptBin with script names that would be invalid as derivation names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This then supports using functions like writeShellScriptBin with script names
that would be invalid as derivation names, which was desired by a user on IRC.
Assuming
sanitizeDerivationNameas introduced in #83241 is correct (which I'm pretty sure it is, comes with covering tests), this change will be fully backwards compatible without any rebuilds.An alternative would be to use
sanitizeDerivationNameinmkDerivationdirectly, but that might influence performance a bit too much for not much of a benefit. This is much more useful for these trivial builders, which especially don't support changing the derivation name on its own.Things done
writeShellScriptBin "{^_^}"newly works after this commit