Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor bits and pieces #4

Merged
merged 9 commits into from Apr 15, 2020
Merged

Minor bits and pieces #4

merged 9 commits into from Apr 15, 2020

Conversation

TrueBrain
Copy link
Member

Just some bits and pieces to bring this repository on-par with the other Python repositories we have. Mostly moving around of code. This PR introduces no functional change what-so-ever.

Currently only the main package was pinnned, which can lead to
unexpected behaviour if one of the dependencies of those packages
change.
webclient/pages/login.py Outdated Show resolved Hide resolved
.github/workflows/testing.yml Outdated Show resolved Hide resolved
webclient/session.py Outdated Show resolved Hide resolved
webclient/main.py Outdated Show resolved Hide resolved
@frosch123
Copy link
Member

I am not sure how the configuration will look like, but now the config variables are split over two files.

This makes the coding-style consistent, and removes the "emotion"
from coding-style.
frosch123
frosch123 previously approved these changes Apr 15, 2020
This makes it a bit easier to understand what belongs where, and
makes a bit easier to see what happens in main.py.
We are not paid per letter, so we can handle this :D
wishlist.txt Outdated Show resolved Hide resolved
webclient/session.py Outdated Show resolved Hide resolved
… other options

Flask comes with click built-in, so it needs a tiny bit of wrapping
to make useful.
@TrueBrain TrueBrain merged commit 715c6cf into OpenTTD:master Apr 15, 2020
@TrueBrain TrueBrain deleted the minor_cleanup branch April 15, 2020 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants