Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firefox-wrapper: remove dead npapi plugin code #85307

Merged
merged 2 commits into from Apr 17, 2020
Merged

firefox-wrapper: remove dead npapi plugin code #85307

merged 2 commits into from Apr 17, 2020

Conversation

xaverdh
Copy link
Contributor

@xaverdh xaverdh commented Apr 15, 2020 •
edited

Motivation for this change

Support for npapi plugins (except for flash) was dropped from firefox some time ago. None of the versions in nixpkgs actually supports them.
So remove support for them from the wrapper.

Things done
  • Verified that the hash does not change when building with default options
  • Tested that building with one of the removed nixpkgs options throws an error as expected

@xaverdh xaverdh mentioned this pull request Apr 15, 2020
Merged
9 tasks
@xaverdh
Copy link
Contributor Author

xaverdh commented Apr 15, 2020

Most of the plugins in pkgs/applications/networking/browsers/mozilla-plugins/ can probably be removed as well. Not sure if something else is still using them though.

@xaverdh
Copy link
Contributor Author

xaverdh commented Apr 16, 2020

After looking through pkgs/applications/networking/browsers/mozilla-plugins/ and some use of grep, I am fairly sure that everything there except for the flashplayer is unused in nixpkgs. Should I add a commit to this pr for removing them, or over a new pr for that?

@lheckemann
Copy link
Member

IMHO add it to this PR.

@lheckemann lheckemann merged commit 6b23355 into NixOS:master Apr 17, 2020
@xaverdh xaverdh deleted the firefox-plugins-cleanup branch April 17, 2020 12:42
@rycee
Copy link
Member

rycee commented Apr 18, 2020

Sorry, I missed this PR before. It would have been great if the throw could have been a warn for some period of time to avoid hard breaking of existing configurations.

@xaverdh
Copy link
Contributor Author

xaverdh commented Apr 19, 2020

Sorry, I missed this PR before. It would have been great if the throw could have been a warn for some period of time to avoid hard breaking of existing configurations.

You think its worth changing that still?

@rycee
Copy link
Member

rycee commented Apr 19, 2020

I think it should be fine to keep the throw unless more complaints arise. I've removed the options from HM so people's configurations should now build OK again. But for future changes like this it would good to have a grace period during which a warning is printed instead of immediately going for a hard error.

@nh2 nh2 mentioned this pull request Oct 14, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

@lheckemann lheckemann lheckemann approved these changes

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xaverdh @lheckemann @rycee @worldofpeace