Change: embed the main headings of all pages in header-elements #3
+22
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrueBrain
approved these changes
Apr 14, 2020
|
Just make the PRs how you seem fit; we figure it out afterwards. Cannot merge atm because of draft status :) |
|
Then let's split it into small independent portions. |
frosch123
pushed a commit
to frosch123/bananas-frontend-web
that referenced
this pull request
Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change provides an additional bit of semantics. It makes it also easier to format the page header (including the sub headings) independent from the rest of the pages with only descendant selectors (i.e. with
header h1or (if really necessary)body > header h1).Additionally I want to replace the
h3in the headers withp. Is it recommended to add a second (or amended) commit here or to deliver it in a separate PR?There is more in the pipeline but I want to split it into independent steps.