Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: embed the main headings of all pages in header-elements #3

Merged
merged 1 commit into from Apr 15, 2020

Conversation

auge8472
Copy link
Contributor

@auge8472 auge8472 commented Apr 14, 2020

This change provides an additional bit of semantics. It makes it also easier to format the page header (including the sub headings) independent from the rest of the pages with only descendant selectors (i.e. with header h1 or (if really necessary) body > header h1).

Additionally I want to replace the h3 in the headers with p. Is it recommended to add a second (or amended) commit here or to deliver it in a separate PR?

There is more in the pipeline but I want to split it into independent steps.

@TrueBrain
Copy link
Member

Just make the PRs how you seem fit; we figure it out afterwards. Cannot merge atm because of draft status :)

@auge8472
Copy link
Contributor Author

Then let's split it into small independent portions.

@auge8472 auge8472 marked this pull request as ready for review April 15, 2020 07:25
@TrueBrain TrueBrain merged commit 28bacf1 into OpenTTD:master Apr 15, 2020
@auge8472 auge8472 deleted the html-overhaul branch April 15, 2020 15:59
frosch123 pushed a commit to frosch123/bananas-frontend-web that referenced this pull request Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants