Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/hydra
base: a42cf35a1c49
Choose a base ref
...
head repository: NixOS/hydra
compare: 87837f1d8290
Choose a head ref
  • 4 commits
  • 26 files changed
  • 2 contributors

Commits on Apr 15, 2020

  1. Get rid of dependency to SQLite 

    SQLite isn't properly supported by Hydra for a few years now[1], but
Hydra still depends on it. Apart from a slightly bigger closure this can
cause confusion by users since Hydra picks up SQLite rather than
PostgreSQL by default if HYDRA_DBI isn't configured properly[2]

[1] 78974ab
[2] https://logs.nix.samueldr.com/nixos-dev/2020-04-10#3297342;
    @Ma27
    Ma27 committed Apr 15, 2020
    Copy the full SHA
    efcbc08 View commit details
    Browse the repository at this point in the history

  2. Remove Hydra::Helper::nix::txn_do from the Perl code 

    To quote the function's comment:

  Awful hack to handle timeouts in SQLite: just retry the transaction.
  DBD::SQLite *has* a 30 second retry window, but apparently it
  doesn't work.

Since SQLite is now dropped entirely, this wrapper can be removed
completely.
    @Ma27
    Ma27 committed Apr 15, 2020
    Copy the full SHA
    721c764 View commit details
    Browse the repository at this point in the history

  3. Re-add DBDSQLite since it's needed by the Perl-bindings of Nix

    @Ma27
    Ma27 committed Apr 15, 2020
    Copy the full SHA
    16a8b4d View commit details
    Browse the repository at this point in the history

  4. Merge pull request #737 from Ma27/rm-sqlite 

    Get rid of dependency to SQLite
    @edolstra
    edolstra committed Apr 15, 2020
    Copy the full SHA
    87837f1 View commit details
    Browse the repository at this point in the history