Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git-lfs: git config and git hook should refer to full path of git-lfs #85264

Closed
wants to merge 1 commit into from
Closed

git-lfs: git config and git hook should refer to full path of git-lfs #85264

wants to merge 1 commit into from
+205 −0

Conversation

kalbasit
Copy link
Member

Motivation for this change

When running nix run nixpkgs.git-lfs -c git-lfs install, the update git config and the generated hook do not refer to git-lfs in its full path resulting in GUI applications and CLI commands outside of nix-shell to fail.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kalbasit
Copy link
Member Author

@GrahamcOfBorg build git-lfs

@kalbasit kalbasit mentioned this pull request Apr 22, 2021
Draft
10 tasks
@stale
Copy link

stale bot commented Jun 7, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 7, 2021
@kalbasit
Copy link
Member Author

kalbasit commented Jun 8, 2021

I'm going to close this in favor of #120270.

@kalbasit kalbasit closed this Jun 8, 2021
@kalbasit kalbasit deleted the try-lorri branch June 8, 2021 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: merge conflict 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kalbasit @ryantm