Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chromedriver: 80.0.3987.16 -> 81.0.4044.69 #85302

Merged
merged 1 commit into from Apr 16, 2020
Merged

chromedriver: 80.0.3987.16 -> 81.0.4044.69 #85302

merged 1 commit into from Apr 16, 2020

Conversation

das-g
Copy link
Member

@das-g das-g commented Apr 15, 2020

Motivation for this change

Bring in sync with chromium version, so that chromedriver and chromium can be used together. See https://chromedriver.chromium.org/downloads/version-selection

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Result of nixpkgs-review 1

1 package marked as broken and skipped:
  • self
3 package built:
  • chromedriver
  • selendroid
  • selenium-server-standalone

@ofborg ofborg bot requested review from cillianderoiste and marsam April 15, 2020 14:18
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/how-to-best-keep-webdrivers-in-sync-with-browsers/6716/1

@marsam marsam merged commit 50db521 into NixOS:master Apr 16, 2020
@das-g das-g mentioned this pull request Apr 16, 2020
Closed
10 tasks
das-g added a commit to das-g/nixpkgs that referenced this pull request Apr 16, 2020
@das-g
chromedriver: 78.0.3904.105 -> 81.0.4044.69
347f887 
backport of NixOS#85302
@das-g das-g deleted the chromedriver-81.0.4044 branch April 16, 2020 03:16
das-g added a commit to das-g/nixpkgs that referenced this pull request Apr 16, 2020
@das-g
chromedriver: 78.0.3904.70 -> 81.0.4044.69
d219b7b 
backport of NixOS#85302
@das-g das-g mentioned this pull request Apr 16, 2020
Merged
10 tasks
stigok pushed a commit to stigok/nixpkgs that referenced this pull request Jun 12, 2020
@das-g @stigok
chromedriver: 78.0.3904.70 -> 81.0.4044.69
1c2bc61 
backport of NixOS#85302
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cillianderoiste cillianderoiste Awaiting requested review from cillianderoiste

@marsam marsam Awaiting requested review from marsam

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@das-g @nixos-discourse @marsam