use declarative setuptools config #358
Conversation
Codecov Report
@@ Coverage Diff @@
## master #358 +/- ##
=======================================
Coverage 82.60% 82.60%
=======================================
Files 35 35
Lines 5955 5955
Branches 1210 1210
=======================================
Hits 4919 4919
Misses 871 871
Partials 165 165 Continue to review full report at Codecov.
|
graingert
force-pushed
the
use-declarative-setup-config
branch
from
18f50d2
to
99165bc
Compare
local_scheme.py
Outdated
| @@ -0,0 +1,6 @@ | |||
| def local_scheme(version): | |||
| return ( | |||
There was a problem hiding this comment.
Could you use the old code for this function please? The changed version is harder to understand IMO.
There was a problem hiding this comment.
This code has been moved into setuptools-scm-node-and-dirty-tag, it could be moved back inline once pypa/setuptools_scm#418 or pypa/setuptools_scm#419 land
|
Is |
|
it is still required
Thomas Grainger
…On Wed, 15 Apr 2020 at 11:52, whitequark ***@***.***> wrote:
Is setup.py required after these changes, or is it only left for
compatibility?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#358 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADFATG7QZLJYU4ZZX3PLXTRMWGXHANCNFSM4MIOT2UA>
.
|
graingert
force-pushed
the
use-declarative-setup-config
branch
2 times, most recently
from
c1a2597
to
87b1be4
Compare
graingert
force-pushed
the
use-declarative-setup-config
branch
from
87b1be4
to
4c6070d
Compare
|
Looks like the setuptools_scm maintainer isn't planning to implement the necessary functionality himself (which is perfectly fine!); I don't have time to do that either. Unless someone wants to implement pypa/setuptools_scm#419 I propose we postpone migration to declarative setuptools configuration indefinitely, since there is very little downside to that. |
|
Turns out it's actually enough to have a minimal @graingert Thank you for your effort, even if in the end it was not used. If setuptools_scm ever gains configurable version formats I'll resurrect this PR. |
No description provided.