xfce: update most packages #85318

romildo · 2020-04-15T18:01:56Z

Motivation for this change

common-updater: change default development version check to false
xfce.exo: 0.12.8 -> 0.12.11
xfce.exo: add support for gtk2, besides gtk3
xfce.gigolo: 0.5.0 -> 0.5.1
xfce.parole: 1.0.4 -> 1.0.5
xfce.thunar: 1.8.9 -> 1.8.14
xfce.tumbler: 0.2.7 -> 0.2.8
xfce.xfburn: 0.6.1 -> 0.6.2
xfce.xfce4-battery-plugin: 1.1.2 -> 1.1.3
xfce.xfce4-clipman-plugin: 1.4.3 -> 1.6.1
xfce.xfce4-cpugraph-plugin: 1.0.5 -> 1.1.0
xfce.xfce4-dict-plugin: remove
xfce.xfce4-dict: 0.8.2 -> 0.8.3
xfce.xfce4-embed-plugin: update meta and buildInputs
xfce.xfce4-eyes-plugin: 4.4.4 -> 4.5.0
xfce.xfce4-fsguard-plugin: 1.0.2 -> 1.1.1
xfce.xfce4-genmon-plugin: 3.4.0 -> 4.0.2
xfce.xfce4-hardware-monitor-plugin: update meta
xfce.xfce4-icon-theme: update gtk dependency and add license
xfce.xfce4-mailwatch-plugin: remove broken status
xfce.xfce4-mpc-plugin: 0.4.5 -> 0.5.2
xfce.xfce4-netload-plugin: 1.3.1 -> 1.3.2
xfce.xfce4-netload-plugin: odd minor version number is not unstable
xfce.xfce4-notes-plugin: 1.7.7 -> 1.8.1
xfce.xfce4-notifyd: 0.4.4 -> 0.6.0
xfce.xfce4-panel: 4.14.0 -> 4.14.3
xfce.xfce4-power-manager: 1.6.5 -> 1.6.6
xfce.xfce4-pulseaudio-plugin: 0.4.2 -> 0.4.3
xfce.xfce4-screenshooter: 1.9.5 -> 1.9.7
xfce.xfce4-sensors-plugin: 1.2.6 -> 1.3.92
xfce.xfce4-session: 4.14.0 -> 4.14.2
xfce.xfce4-settings: 4.14.0 -> 4.14.3
xfce.xfce4-systemload-plugin: 1.1.2 -> 1.2.3
xfce.xfce4-taskmanager: 1.2.2 -> 1.2.3
xfce.xfce4-terminal: 0.8.8 -> 0.8.9.2
xfce.xfce4-timer-plugin: 1.6.0 -> 1.7.0
xfce.xfce4-vala-panel-appmenu-plugin: 0.6.94 -> 0.7.3
xfce.xfce4-weather-plugin: 0.8.10 -> 0.10.1
xfce.xfce4-windowck-plugin: 0.4.4 -> 0.4.6
xfce.xfdashboard: 0.7.5 -> 0.7.7
xfce.xfdesktop: 4.14.1 -> 4.14.2

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Ensured that relevant documentation is up to date
[] Fits CONTRIBUTING.md.

romildo · 2020-04-15T21:34:19Z

@GrahamcOfBorg build xfce.exo xfce.gigolo xfce.parole xfce.thunar xfce.tumbler xfce.xfburn xfce.xfce4-battery-plugin xfce.xfce4-clipman-plugin xfce.xfce4-cpugraph-plugin xfce.xfce4-dict xfce.xfce4-eyes-plugin xfce.xfce4-fsguard-plugin xfce.xfce4-genmon-plugin xfce.xfce4-mpc-plugin xfce.xfce4-netload-plugin xfce.xfce4-notes-plugin xfce.xfce4-notifyd xfce.xfce4-panel xfce.xfce4-power-manager xfce.xfce4-pulseaudio-plugin xfce.xfce4-screenshooter xfce.xfce4-sensors-plugin xfce.xfce4-session xfce.xfce4-settings xfce.xfce4-systemload-plugin xfce.xfce4-taskmanager xfce.xfce4-terminal xfce.xfce4-timer-plugin xfce.xfce4-vala-panel-appmenu-plugin xfce.xfce4-weather-plugin xfce.xfce4-windowck-plugin xfce.xfdashboard xfce.xfdesktop

romildo · 2020-04-16T04:57:47Z

@GrahamcOfBorg build xfce.exo xfce.gigolo xfce.parole xfce.thunar xfce.tumbler xfce.xfburn xfce.xfce4-battery-plugin xfce.xfce4-clipman-plugin xfce.xfce4-cpugraph-plugin xfce.xfce4-dict xfce.xfce4-embed-plugin xfce.xfce4-eyes-plugin xfce.xfce4-fsguard-plugin xfce.xfce4-genmon-plugin xfce.xfce4-hardware-monitor-plugin xfce.xfce4-icon-theme xfce.xfce4-mailwatch-plugin xfce.xfce4-mpc-plugin xfce.xfce4-netload-plugin xfce.xfce4-notes-plugin xfce.xfce4-notifyd xfce.xfce4-panel xfce.xfce4-power-manager xfce.xfce4-pulseaudio-plugin xfce.xfce4-screenshooter xfce.xfce4-sensors-plugin xfce.xfce4-session xfce.xfce4-settings xfce.xfce4-systemload-plugin xfce.xfce4-taskmanager xfce.xfce4-terminal xfce.xfce4-timer-plugin xfce.xfce4-vala-panel-appmenu-plugin xfce.xfce4-weather-plugin xfce.xfce4-windowck-plugin xfce.xfdashboard xfce.xfdesktop

romildo · 2020-04-16T11:22:26Z

@GrahamcOfBorg build xfce.exo xfce.gigolo xfce.parole xfce.thunar xfce.tumbler xfce.xfburn xfce.xfce4-battery-plugin xfce.xfce4-clipman-plugin xfce.xfce4-cpugraph-plugin xfce.xfce4-dict xfce.xfce4-embed-plugin xfce.xfce4-eyes-plugin xfce.xfce4-fsguard-plugin xfce.xfce4-genmon-plugin xfce.xfce4-hardware-monitor-plugin xfce.xfce4-icon-theme xfce.xfce4-mailwatch-plugin xfce.xfce4-mpc-plugin xfce.xfce4-netload-plugin xfce.xfce4-notes-plugin xfce.xfce4-notifyd xfce.xfce4-panel xfce.xfce4-power-manager xfce.xfce4-pulseaudio-plugin xfce.xfce4-screenshooter xfce.xfce4-sensors-plugin xfce.xfce4-session xfce.xfce4-settings xfce.xfce4-systemload-plugin xfce.xfce4-taskmanager xfce.xfce4-terminal xfce.xfce4-timer-plugin xfce.xfce4-vala-panel-appmenu-plugin xfce.xfce4-weather-plugin xfce.xfce4-windowck-plugin xfce.xfdashboard xfce.xfdesktop

jD91mZM2

I don't really the the appmenu plugin anymore and should remove myself as a maintainer, but I mean yeah, the changes look good!

worldofpeace · 2020-04-19T20:48:56Z

@GrahamcOfBorg test xfce

worldofpeace

LGTM, ran every default program in a VM.

worldofpeace · 2020-04-19T21:40:32Z

Actually, how are we going to handle migration for eb19356 ?

worldofpeace · 2020-04-19T21:41:42Z

I also thing we removed gtk2 from exo already dd8c333. gtk2 support is going to be removed anyways IIRC, and we're going to release 20.09 with a new version of XFCE.

stale

romildo · 2020-04-19T22:04:28Z

Actually, how are we going to handle migration for eb19356 ?

Maybe just throw message:

  xfce4-dict-plugin = throw "xfce4-dict-plugin is now part of xfce4-dict.";

romildo · 2020-04-19T22:12:16Z

I also thing we removed gtk2 from exo already dd8c333. gtk2 support is going to be removed anyways IIRC, and we're going to release 20.09 with a new version of XFCE.

Some XFCE applications and plugins still uses gtk2. Some other core components (xfce4-panel, libxfce4ui) still enable it for that reason. Why do not enable it too for exo, so that some plugins can be built?

With the next XFCE release we expect the definitive remove of gtk2, though.

worldofpeace · 2020-04-19T22:16:05Z

I also thing we removed gtk2 from exo already dd8c333. gtk2 support is going to be removed anyways IIRC, and we're going to release 20.09 with a new version of XFCE.

Some XFCE applications and plugins still uses gtk2. Some other core components (xfce4-panel, libxfce4ui) still enable it for that reason. Why do not enable it too for exo, so that some plugins can be built?

With the next XFCE release we expect the definitive remove of gtk2, though.

Hmm, I guess we can just clean it up when they release.

worldofpeace · 2020-04-19T22:16:21Z

Actually, how are we going to handle migration for eb19356 ?

Maybe just throw message:
  xfce4-dict-plugin = throw "xfce4-dict-plugin is now part of xfce4-dict.";

Sounds good, there's an alias section in xfce/default.nix

worldofpeace

Squash the fixup and merge is fine 👍

- The xfce4-dict-plugin is now part of xfce4-dict - See https://goodies.xfce.org/projects/panel-plugins/xfce4-dict-plugin - Throws a message

ofborg bot added 6.topic: xfce The Xfce Desktop Environment 8.has: clean-up labels Apr 15, 2020

ofborg bot requested review from volth, jD91mZM2 and AndersonTorres April 15, 2020 18:09

ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 labels Apr 15, 2020

ofborg bot requested a review from edolstra April 16, 2020 04:56

romildo added 2 commits April 16, 2020 08:06

common-updater: change default development version check to false

7d84c7c

xfce.xfce4-netload-plugin: odd minor version number is not unstable

cef0895

jD91mZM2 approved these changes Apr 16, 2020

View reviewed changes

worldofpeace previously approved these changes Apr 19, 2020

View reviewed changes

ofborg bot requested a review from jD91mZM2 April 19, 2020 22:37

worldofpeace approved these changes Apr 19, 2020

View reviewed changes

romildo added 5 commits April 19, 2020 20:38

xfce.xfce4-dict-plugin: remove

f578c51

- The xfce4-dict-plugin is now part of xfce4-dict - See https://goodies.xfce.org/projects/panel-plugins/xfce4-dict-plugin - Throws a message

xfce.exo: 0.12.8 -> 0.12.11

e18514f

xfce.gigolo: 0.5.0 -> 0.5.1

20b701d

xfce.parole: 1.0.4 -> 1.0.5

279bb5a

xfce.xfce4-terminal: 0.8.8 -> 0.8.9.2

c0c96e8

romildo added 28 commits April 19, 2020 20:38

xfce.xfce4-cpugraph-plugin: 1.0.5 -> 1.1.0

8fdb483

xfce.xfce4-eyes-plugin: 4.4.4 -> 4.5.0

118415a

xfce.xfce4-fsguard-plugin: 1.0.2 -> 1.1.1

81cef8f

xfce.xfce4-netload-plugin: 1.3.1 -> 1.3.2

79dc51f

xfce.xfce4-genmon-plugin: 3.4.0 -> 4.0.2

0c6b804

xfce.xfce4-notifyd: 0.4.4 -> 0.6.0

361b67e

xfce.xfce4-mpc-plugin: 0.4.5 -> 0.5.2

da4b533

xfce.xfce4-notes-plugin: 1.7.7 -> 1.8.1

7d84084

xfce.xfce4-panel: 4.14.0 -> 4.14.3

bed7bb9

xfce.xfce4-power-manager: 1.6.5 -> 1.6.6

f0a62ce

xfce.xfce4-pulseaudio-plugin: 0.4.2 -> 0.4.3

869ad7c

xfce.xfce4-screenshooter: 1.9.5 -> 1.9.7

39343ed

xfce.xfce4-session: 4.14.0 -> 4.14.2

cb84711

xfce.xfce4-settings: 4.14.0 -> 4.14.3

80227a5

xfce.xfce4-taskmanager: 1.2.2 -> 1.2.3

fec32ec

xfce.xfce4-sensors-plugin: 1.2.6 -> 1.3.92

4bf4f84

xfce.xfce4-systemload-plugin: 1.1.2 -> 1.2.3

39621eb

xfce.xfce4-vala-panel-appmenu-plugin: 0.6.94 -> 0.7.3

6ce6bdf

xfce.xfce4-windowck-plugin: 0.4.4 -> 0.4.6

37be87b

xfce.xfce4-timer-plugin: 1.6.0 -> 1.7.0

360be69

xfce.xfdashboard: 0.7.5 -> 0.7.7

68569ee

xfce.xfce4-weather-plugin: 0.8.10 -> 0.10.1

ed93bfb

xfce.xfdesktop: 4.14.1 -> 4.14.2

a2c9736

xfce.exo: add support for gtk2, besides gtk3

11188c1

xfce.xfce4-mailwatch-plugin: remove broken status

21fb9c5

xfce.xfce4-embed-plugin: update meta and buildInputs

c7c0940

xfce.xfce4-hardware-monitor-plugin: update meta

fc4a10e

xfce.xfce4-icon-theme: update gtk dependency and add license

c5d8f23

romildo merged commit 76f2f29 into NixOS:master Apr 19, 2020

romildo deleted the upd.xfce branch April 19, 2020 23:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

xfce: update most packages #85318

xfce: update most packages #85318

romildo commented Apr 15, 2020 •

edited

romildo commented Apr 15, 2020

romildo commented Apr 16, 2020

romildo commented Apr 16, 2020

jD91mZM2 left a comment

worldofpeace commented Apr 19, 2020

worldofpeace left a comment

worldofpeace commented Apr 19, 2020

worldofpeace commented Apr 19, 2020

romildo commented Apr 19, 2020

romildo commented Apr 19, 2020

worldofpeace commented Apr 19, 2020

worldofpeace commented Apr 19, 2020

worldofpeace left a comment

xfce: update most packages #85318

xfce: update most packages #85318

Conversation

romildo commented Apr 15, 2020 • edited

Motivation for this change

Things done

romildo commented Apr 15, 2020

romildo commented Apr 16, 2020

romildo commented Apr 16, 2020

jD91mZM2 left a comment

Choose a reason for hiding this comment

worldofpeace commented Apr 19, 2020

worldofpeace left a comment

Choose a reason for hiding this comment

worldofpeace commented Apr 19, 2020

worldofpeace commented Apr 19, 2020

romildo commented Apr 19, 2020

romildo commented Apr 19, 2020

worldofpeace commented Apr 19, 2020

worldofpeace commented Apr 19, 2020

worldofpeace left a comment

Choose a reason for hiding this comment

romildo commented Apr 15, 2020 •

edited