Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xournalpp: 1.0.17 -> 1.0.18 #85326

Merged
merged 1 commit into from Apr 21, 2020
Merged

xournalpp: 1.0.17 -> 1.0.18 #85326

merged 1 commit into from Apr 21, 2020

Conversation

sikmir
Copy link
Member

@sikmir sikmir commented Apr 15, 2020

Motivation for this change

Changelog

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from andrew-d April 15, 2020 20:17
symphorien
symphorien approved these changes Apr 15, 2020
View reviewed changes
Copy link
Member

@symphorien symphorien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran nix-review and checked quickly that I can annotate a pdf and save it.

andrew-d
andrew-d approved these changes Apr 17, 2020
View reviewed changes
Copy link
Contributor

@andrew-d andrew-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that it compiles and runs correctly; changelog looks good as well.

@FRidh FRidh merged commit 42d2903 into NixOS:master Apr 21, 2020
@sikmir sikmir deleted the xournalpp branch April 21, 2020 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrew-d andrew-d andrew-d approved these changes

@symphorien symphorien symphorien approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sikmir @andrew-d @symphorien @FRidh