Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

afterburn: init at 4.6.0 #68680

Merged
merged 1 commit into from Jan 21, 2021
Merged

afterburn: init at 4.6.0 #68680

merged 1 commit into from Jan 21, 2021

Conversation

arianvp
Copy link
Member

@arianvp arianvp commented Sep 13, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@arianvp arianvp changed the title Afterburn afterburn: init at 4.1.3 Sep 13, 2019
jonringer
jonringer reviewed Sep 13, 2019
View reviewed changes
pkgs/tools/admin/afterburn/default.nix Outdated Show resolved Hide resolved
pkgs/tools/admin/afterburn/default.nix Outdated Show resolved Hide resolved
pkgs/tools/admin/afterburn/default.nix Outdated Show resolved Hide resolved
pkgs/tools/admin/afterburn/default.nix Outdated Show resolved Hide resolved
jonringer
jonringer approved these changes Sep 13, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM (few suggestions above)
binary works
leaf package

@arianvp
Copy link
Member Author

arianvp commented Sep 13, 2019

Please don't merge yet! Still a WIP. For one I want to ship the systemd units that afterburn ships

@jonringer
Copy link
Contributor

systemd services will probably have to be done as nixos modules, unless you're talking about some daemon programs

@arianvp
Copy link
Member Author

arianvp commented Sep 13, 2019 •
edited

Yes but when possible we tend to use the upstream units and set them using the systemd.packages option. That means I don't have to manually keep up with the upstream changes.

@arianvp arianvp force-pushed the afterburn branch 2 times, most recently from e1d2f76 to ed31e3d Compare September 13, 2019 19:45
@arianvp arianvp mentioned this pull request Sep 13, 2019
Closed
10 tasks
@arianvp arianvp marked this pull request as ready for review September 13, 2019 19:59
@arianvp arianvp mentioned this pull request Oct 9, 2019
Open
@Lassulus
Copy link
Member

sup with this?

@arianvp
Copy link
Member Author

arianvp commented Oct 25, 2019

In stuck on the comments by @edolstra about not using fixed output derivations for rust (he commented about that in the NixOS module PR). I haven't checked out carnix yet, perhaps that can help

@vyp
Copy link
Member

vyp commented Oct 25, 2019

fyi getting page not found on https://github.com/coreos/cargo

@flokli
Copy link
Contributor

flokli commented Feb 8, 2020 •
edited

How do we want to proceed with this?

@vyp We're referring to cargo, the Rust package manager (as afterburn is written in Rust).

@arianvp arianvp closed this Apr 15, 2020
@arianvp arianvp reopened this Sep 25, 2020
@flokli flokli force-pushed the afterburn branch 2 times, most recently from a6f69bd to f97d9f2 Compare December 31, 2020 21:10
@flokli flokli changed the title afterburn: init at 4.1.3 afterburn: init at 4.6.0 Dec 31, 2020
SuperSandro2000
SuperSandro2000 requested changes Jan 18, 2021
View reviewed changes
pkgs/tools/admin/afterburn/default.nix Outdated Show resolved Hide resolved
pkgs/tools/admin/afterburn/default.nix Outdated Show resolved Hide resolved
pkgs/tools/admin/afterburn/default.nix Outdated Show resolved Hide resolved
pkgs/tools/admin/afterburn/default.nix Outdated Show resolved Hide resolved
@flokli flokli force-pushed the afterburn branch 2 times, most recently from 77ce955 to 11fd28a Compare January 19, 2021 20:27
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 68680 run on x86_64-linux 1

1 package built:
  • afterburn

arianvp
arianvp commented Jan 20, 2021
View reviewed changes
Copy link
Member Author

@arianvp arianvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are also some initrd-specific pieces of afterburn e.g. https://github.com/coreos/afterburn/blob/master/dracut/30afterburn/afterburn-hostname.service

but i guess we should address those in the nixos module ; not here.

So LGTM (though I cant approve as I originally opened this)

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 68680 run on x86_64-linux 1

1 package built:
  • afterburn

@flokli flokli merged commit 126fb3c into NixOS:master Jan 21, 2021
@flokli flokli mentioned this pull request Feb 14, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flokli flokli flokli left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@arianvp @jonringer @Lassulus @vyp @flokli @SuperSandro2000 @ryantm