Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

terraform-compliance: init at v1.2.11 #85322

Merged
merged 5 commits into from Jul 23, 2020
Merged

terraform-compliance: init at v1.2.11 #85322

merged 5 commits into from Jul 23, 2020

Conversation

Charg
Copy link
Contributor

@Charg Charg commented Apr 15, 2020 •
edited by kalbasit

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Charg Charg changed the title terraform-compliance: init v1.1.16 terraform-compliance: init at v1.1.16 Apr 15, 2020
jonringer
jonringer reviewed Apr 16, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To comply with CONTRIBUTING.md please have a commit per package, with the commit subject of the format

<pkg-name>: <subject-line>

for more examples, please look at https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#submitting-changes

you should have around 5 commits.

@kalbasit kalbasit force-pushed the add-terraform-compliance-pkg branch from c29703a to 6e4cd6b Compare June 17, 2020 17:00
@kalbasit
Copy link
Member

@Charg I hope you don't mind, but I force-pushed your branch to address the comments.

@jonringer PTAL.

@ofborg ofborg bot requested a review from multun June 17, 2020 17:08
jonringer
jonringer reviewed Jun 17, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall, i would like some maintainers listed.

If tests aren't available through Pypi, then i would prefer to checkout the source.

pkgs/development/python-modules/junit-xml/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pysingleton/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pysingleton/default.nix Show resolved Hide resolved
@kalbasit kalbasit force-pushed the add-terraform-compliance-pkg branch 3 times, most recently from c639dab to 3734acf Compare July 21, 2020 19:41
@kalbasit
Copy link
Member

overall, i would like some maintainers listed.

If tests aren't available through Pypi, then i would prefer to checkout the source.

@jonringer I've addressed all of your comments except for the tests for the pysingleton module. Unfortunately, the repository for this module was deleted. I did use pythonImportsCheck for it though.

@kalbasit kalbasit changed the title terraform-compliance: init at v1.1.16 terraform-compliance: init at v1.2.11 Jul 21, 2020
@kalbasit
Copy link
Member

@GrahamcOfBorg build python3Packages.colorful python3Packages.pysingleton python3Packages.tag-expressions python3Packages.radish-bdd terraform-compliance

@kalbasit kalbasit requested a review from jonringer July 21, 2020 21:56
kalbasit and others added 5 commits July 21, 2020 16:10
@kalbasit @Charg
pythonPackages.colorful: init at 0.5.4
7c4a19b 
Co-Authored-By: Chris <grkcharge@gmail.com>
@kalbasit @Charg
pythonPackages.pysingleton: init at 0.2.1
86f9646 
Co-Authored-By: Chris <grkcharge@gmail.com>
@kalbasit @Charg
pythonPackages.tag-expressions: init at 1.1.0
d4dae82 
Co-Authored-By: Chris <grkcharge@gmail.com>
@kalbasit @Charg
pythonPackages.radish-bdd: init at 0.13.2
a155661 
Co-Authored-By: Chris <grkcharge@gmail.com>
@kalbasit @Charg
terraform-compliance: init at 1.2.11
817a835 
Co-Authored-By: Chris <grkcharge@gmail.com>
@kalbasit kalbasit force-pushed the add-terraform-compliance-pkg branch from 3734acf to 817a835 Compare July 21, 2020 23:10
@kalbasit
Copy link
Member

I force pushed to re-add @Charg as Co-Author. Not sure when/how the commit author got reset 🤦‍♂️

@GrahamcOfBorg build python3Packages.colorful python3Packages.pysingleton python3Packages.tag-expressions python3Packages.radish-bdd terraform-compliance

@ofborg ofborg bot requested a review from kalbasit July 22, 2020 01:35
@kalbasit
Copy link
Member

Merging this now, @jonringer let me know if you wanted anything different I can file a follow-up PR.

@kalbasit kalbasit merged commit b30286c into NixOS:master Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@multun multun Awaiting requested review from multun

@jonringer jonringer Awaiting requested review from jonringer

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Charg @kalbasit @jonringer