Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sn0int: init at 0.18.2 #85282

Merged
merged 1 commit into from Apr 20, 2020
Merged

sn0int: init at 0.18.2 #85282

merged 1 commit into from Apr 20, 2020

Conversation

xrelkd
Copy link
Contributor

@xrelkd xrelkd commented Apr 15, 2020

Motivation for this change

sn0int is a semi-automatic OSINT framework and package manager

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@xrelkd xrelkd mentioned this pull request Apr 15, 2020
Open
@xrelkd xrelkd changed the title sn0int: init at 0.18.2 [WIP] sn0int: init at 0.18.2 Apr 15, 2020
@xrelkd xrelkd changed the title [WIP] sn0int: init at 0.18.2 sn0int: init at 0.18.2 Apr 15, 2020
@xrelkd xrelkd changed the title sn0int: init at 0.18.2 [WIP] sn0int: init at 0.18.2 Apr 15, 2020
@xrelkd xrelkd force-pushed the add/sn0int branch 5 times, most recently from 31f551f to 5261502 Compare April 15, 2020 13:23
@xrelkd
Copy link
Contributor Author

xrelkd commented Apr 15, 2020

@GrahamcOfBorg build sn0int

@xrelkd xrelkd changed the title [WIP] sn0int: init at 0.18.2 sn0int: init at 0.18.2 Apr 15, 2020
@xrelkd xrelkd force-pushed the add/sn0int branch 2 times, most recently from 4fc4c5f to b85cb44 Compare April 18, 2020 18:26
@xrelkd
Copy link
Contributor Author

xrelkd commented Apr 18, 2020

Hi, @worldofpeace I think this PR got stuck, too. Could you review this PR?
Thank you very much!

worldofpeace
worldofpeace reviewed Apr 18, 2020
View reviewed changes
pkgs/tools/security/sn0int/default.nix Outdated
Comment on lines 21 to 23
# tries to read /etc/resolv.conf, hence fails in sandbox
doCheck = false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems weird https://github.com/kpcyrd/sn0int/blob/b4fbca4e0df80f9d72a514fb3f7d55015200a2f8/src/sandbox/mod.rs#L65 I don't know a lick of rust but #[cfg(target_os = "openbsd")] looks like this statement would only happen on openbsd

Copy link
Contributor Author

@xrelkd xrelkd Apr 18, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the dependencies (https://github.com/kpcyrd/chrootable-https/blob/e8e8e68d0e28ccef78a365af30f53d191b48dd2c/src/dns/mod.rs) tries to read /etc/resolv.conf in the checkPhase, hencd fails in sandbox of nix.
Not just happen on OpenBSD.

@xrelkd
Copy link
Contributor Author

xrelkd commented Apr 20, 2020

Hi @worldofpeace, thanks for the review.
Is there any improvement I can do for this PR?

@worldofpeace
Copy link
Contributor

Hi @worldofpeace, thanks for the review.
Is there any improvement I can do for this PR?

Oops, thanks for reminding me. Could you add what you mentioned above into a comment (doCheck)?

@xrelkd
Copy link
Contributor Author

xrelkd commented Apr 20, 2020

Hi @worldofpeace, thanks for the review!
The commit has been updated as your suggestion.

@worldofpeace worldofpeace merged commit 2a6c9b1 into NixOS:master Apr 20, 2020
@worldofpeace
Copy link
Contributor

@xrelkd Merged ✨

@xrelkd
Copy link
Contributor Author

xrelkd commented Apr 20, 2020

@worldofpeace Thank you!!

sn0int has been added into nixpkgs for #81418 (cc @JoshuaFern)

@xrelkd xrelkd deleted the add/sn0int branch April 20, 2020 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xrelkd @worldofpeace