Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gpgme: Fix build with python on macOS #85287

Merged
merged 2 commits into from Apr 21, 2020
Merged

gpgme: Fix build with python on macOS #85287

merged 2 commits into from Apr 21, 2020

Conversation

kirelagin
Copy link
Member

@kirelagin kirelagin commented Apr 15, 2020 •
edited

  • Replace LD_LIBRARY_PATH with OS-specific name (e.g. DYLD_LIBRARY_PATH
    on macOS).
  • Disable Python tests on macOS, because they use gpg, which fails due
    to a very long socket path (use /nix/var/tmp as default tmpRoot nix#1085).

The former should be fixed upstream (patch). The latter is a Nix-specific issue,
but it can be worked-around upstream by making Python tests respect
--disable-gpg-test.

Fixes #70996.
Related NixOS/nix#1085.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kirelagin
pgpgme: Fix build with python on macOS
9bb1b49 
* Replace LD_LIBRARY_PATH with OS-specific name (e.g. DYLD_LIBRARY_PATH
  on macOS).
* Disable Python tests on macOS, because they use gpg, which fails due
  to a very long socket path (NixOS/nix#1085).

The former should be fixed upstream. The latter is a Nix-specific issue,
but it can be worked-around upstream by making Python tests respect
--disable-gpg-test.
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Apr 15, 2020
@ofborg ofborg bot requested a review from primeos April 15, 2020 10:33
@Mic92 Mic92 changed the title pgpgme: Fix build with python on macOS gpgme: Fix build with python on macOS Apr 15, 2020
@Mic92
gpgme: convert macos sed patch scripts to patch files
6e92ea1 
This is less brittle and breaks loud if the code changes.
Also remove the /usr/bin/file patch. It is not really required
for the build to work, the generated warning is harmless.
@FRidh FRidh changed the base branch from master to staging April 21, 2020 06:36
@FRidh FRidh merged commit c88f04c into NixOS:staging Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@primeos primeos Awaiting requested review from primeos

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 11-100 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

darwin: gpgme build broken
3 participants
@kirelagin @Mic92 @FRidh