Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meshcommander: init at 0.8.0-e #85286

Merged
merged 1 commit into from Jan 27, 2021
Merged

meshcommander: init at 0.8.0-e #85286

merged 1 commit into from Jan 27, 2021

Conversation

tfc
Copy link
Contributor

@tfc tfc commented Apr 15, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@tfc tfc requested a review from marsam April 15, 2020 10:18
@tfc tfc requested a review from flokli April 24, 2020 07:39
@flokli
Copy link
Contributor

flokli commented Apr 24, 2020

I don't feel myself comfortable enough in the NodeJS ecosystem, sorry.

@flokli flokli removed their request for review April 24, 2020 11:46
@marsam
Copy link
Contributor

marsam commented Apr 24, 2020

Sorry for the delay. Could you follow the steps listed in "To add a package from NPM to nixpkgs" https://nixos.org/nixpkgs/manual/#node.js?
Please ping me if you have any issue

@tfc
Copy link
Contributor Author

tfc commented Jan 27, 2021

@marsam i am a bit late, but i did what you suggested. Thank you for your input.

@ofborg ofborg bot requested a review from midchildan January 27, 2021 09:33
@marsam
Copy link
Contributor

marsam commented Jan 27, 2021

@GrahamcOfBorg build nodePackages.meshcommander
@GrahamcOfBorg build nodePackages.pyright nodePackages.prettier nodePackages.expo-cli nodePackages.typescript

@marsam marsam merged commit e686acb into NixOS:master Jan 27, 2021
@tfc tfc deleted the nodejs-meshcommander branch January 28, 2021 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam Awaiting requested review from marsam

@midchildan midchildan Awaiting requested review from midchildan

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tfc @flokli @marsam @ryantm @alyssais