Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.dotnetcore2: 2.1.11 -> 2.1.13 #85329

Merged
merged 1 commit into from Apr 21, 2020
Merged

python3Packages.dotnetcore2: 2.1.11 -> 2.1.13 #85329

merged 1 commit into from Apr 21, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Apr 15, 2020 •
edited

Motivation for this change

routine update

instead of installing just the *.py s, remove the extraneous entry point.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
python3Packages.dotnetcore2: 2.1.11 -> 2.1.13
19410b5 
instead of installing only what's needed, remove extraneous executable
@jonringer jonringer requested a review from FRidh as a code owner April 15, 2020 21:08
@FRidh
Copy link
Member

FRidh commented Apr 21, 2020

@GrahamcOfBorg build python3Packages.dotnetcore2

@FRidh
Copy link
Member

FRidh commented Apr 21, 2020

Would it be possible to later build this from source? We have dotnet-packages.nix.

@jonringer
Copy link
Contributor Author

jonringer commented Apr 21, 2020 •
edited

It's from my sister team at work, they don't publish source. It's essentially a wrapper for installing dotnetcore binaries, and then exposing them through python bindings. (it's a hack, apparently it's too much to ask for people to install dotnet binaries)

https://pypi.org/project/dotnetcore2/

@jonringer jonringer merged commit 5d4162e into NixOS:master Apr 21, 2020
@jonringer jonringer deleted the bump-dotnetcore2 branch August 15, 2020 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @FRidh