nixos/networkmanager: restart dispatcher when nameservers change #85328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, you can change the list of appended or prepended nameservers in your NetworkManager config, and nixos-rebuild doesn't cause those changes to come into effect.
flokli
approved these changes
Apr 16, 2020
| @@ -451,7 +451,7 @@ in { | |||
|
|
|||
| systemd.services.NetworkManager-dispatcher = { | |||
| wantedBy = [ "network.target" ]; | |||
| restartTriggers = [ configFile ]; | |||
| restartTriggers = [ configFile overrideNameserversScript ]; | |||
There was a problem hiding this comment.
too bad we can't just watch on the directory, but this contains the nameserver list, so it should work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, you can change the list of appended or prepended nameservers in
your NetworkManager config, and nixos-rebuild doesn't cause those changes to
come into effect.
I don't have much experience with the module system, so thorough review would be appreciated.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)