Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First change is to replace the
h3
inheader
withp
. There are for me two arguments. First is, that one should not skip heading levels (that would cause a change fromh1
followed byh3
toh1
followed byh2
) and second (and IMHO more important), the information, stored in theh3
, are no headings in itself. We can format the content also in paragraphs eye-catching if wished.One additional issue. I made testing pages for several contents to be able to understand the desired HTML structure (i.e. loops here and there and the table structure especially of the manager_package_list.html with it's many rowspans and colspans in the table header). Doing so, I came across the menu structure and the order of the main blocks (page header, menu, content). So I played around and came up with a first draft of a menu in a list structure (see therefore this Gist). During the tests I changed the order of the HTML-source from menu=>header=>content to header=>menu=>content. See therefore the creenshot and ignore the "Presented by BaNaNaS".
If I want to change the order also in the code, I have to alter the position of
{% block header %}{% endblock %}
in the base.html, havn't I (file name should have been order.html)?Is this desirable at all? If so, I would like to add this small additional change to this PR.