openmvg: 1.3 -> 1.5 (unbreak) #85330
Merged
+7
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
10.rebuild-darwin: 0
danieldk
suggested changes
Jun 22, 2020
| @@ -8,15 +8,13 @@ | |||
| , enableDocs ? false }: | |||
|
|
|||
| stdenv.mkDerivation rec { | |||
| version = "1.3"; | |||
| version = "1.5"; | |||
There was a problem hiding this comment.
Seems like 1.6 is out now.
| pname = "openmvg"; | ||
|
|
||
| src = fetchgit { | ||
| url = "https://www.github.com/openmvg/openmvg.git"; | ||
|
|
||
| # Tag v1.1 | ||
| rev = "refs/tags/v${version}"; |
There was a problem hiding this comment.
Suggested change
| rev = "refs/tags/v${version}"; | |
| rev = "v${version}"; |
|
Looks good to me! |
|
@ofborg build openmvg |
danieldk
approved these changes
Aug 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Unbreak OpenMVG. Turns out all that was needed was to bump the version.
Things done
I successfully did a 3D photogrammetry reconstruction with this change.
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)